From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38B5AA09D2 for ; Wed, 11 Nov 2020 08:00:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1490F493D; Wed, 11 Nov 2020 08:00:39 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 7A32F31FC; Wed, 11 Nov 2020 08:00:37 +0100 (CET) In-Reply-To: <20201111064936.768604-35-jiawenwu@trustnetic.com> References: <20201111064936.768604-35-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20201111070037.7A32F31FC@dpdk.org> Date: Wed, 11 Nov 2020 08:00:37 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw83974 [PATCH v2 34/37] net/txgbe: add security session create operation X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/83974 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects? #99: FILE: drivers/net/txgbe/txgbe_ipsec.c:16: +#define CMP_IP(a, b) (\ + (a).ipv6[0] == (b).ipv6[0] && \ + (a).ipv6[1] == (b).ipv6[1] && \ + (a).ipv6[2] == (b).ipv6[2] && \ + (a).ipv6[3] == (b).ipv6[3]) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects? #99: FILE: drivers/net/txgbe/txgbe_ipsec.c:16: +#define CMP_IP(a, b) (\ + (a).ipv6[0] == (b).ipv6[0] && \ + (a).ipv6[1] == (b).ipv6[1] && \ + (a).ipv6[2] == (b).ipv6[2] && \ + (a).ipv6[3] == (b).ipv6[3]) CHECK:CAMELCASE: Avoid CamelCase: #173: FILE: drivers/net/txgbe/txgbe_ipsec.c:90: + if (ic_session->dst_ip.type == IPv6) { CHECK:CAMELCASE: Avoid CamelCase: #176: FILE: drivers/net/txgbe/txgbe_ipsec.c:93: + } else if (ic_session->dst_ip.type == IPv4) { WARNING:REPEATED_WORD: Possible repeated word: 'crypto' #401: FILE: drivers/net/txgbe/txgbe_ipsec.h:42: +/** inline crypto crypto private session structure */ total: 0 errors, 1 warnings, 4 checks, 355 lines checked