From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6C11A04B1 for ; Tue, 24 Nov 2020 12:51:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE715C910; Tue, 24 Nov 2020 12:51:28 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id EF50AC914; Tue, 24 Nov 2020 12:51:26 +0100 (CET) In-Reply-To: <1606218596-17896-1-git-send-email-viacheslavo@nvidia.com> References: <1606218596-17896-1-git-send-email-viacheslavo@nvidia.com> To: test-report@dpdk.org Cc: Viacheslav Ovsiienko Message-Id: <20201124115126.EF50AC914@dpdk.org> Date: Tue, 24 Nov 2020 12:51:26 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw84503 [PATCH] app/testpmd: fix str2flowtype not used warnings X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/84503 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #66: FILE: app/test-pmd/cmdline.c:10100: +#define IPV4_ADDR_TO_UINT(ip_addr, ip) \ +do { \ + if ((ip_addr).family == AF_INET) \ + (ip) = (ip_addr).addr.ipv4.s_addr; \ + else { \ + printf("invalid parameter. "); \ + return; \ + } \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #76: FILE: app/test-pmd/cmdline.c:10110: +#define IPV6_ADDR_TO_ARRAY(ip_addr, ip) \ +do { \ + if ((ip_addr).family == AF_INET6) \ + rte_memcpy(&(ip), \ + &((ip_addr).addr.ipv6), \ + sizeof(struct in6_addr)); \ + else { \ + printf("invalid parameter. "); \ + return; \ + } \ +} while (0) total: 0 errors, 2 warnings, 60 lines checked