From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: dheemanth <dheemanthm@vmware.com>
Subject: [dpdk-test-report] |WARNING| pw84986 [PATCH v1 2/2] linux/kni: Added support for KNI multiple fifos
Date: Thu, 10 Dec 2020 17:21:13 +0100 (CET) [thread overview]
Message-ID: <20201210162113.7C162BE73@dpdk.org> (raw)
In-Reply-To: <1607478454-23218-1-git-send-email-dheemanthm@vmware.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/84986
_coding style issues_
ERROR:TRAILING_WHITESPACE: trailing whitespace
#220: FILE: kernel/linux/kni/kni_fifo.h:49:
+^I^I * between 0 and fifo->len-1. $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#228: FILE: kernel/linux/kni/kni_fifo.h:55:
+^I^I^Iif (unlikely(free_entries == 0)) $
WARNING:TABSTOP: Statements should start on a tabstop
#241: FILE: kernel/linux/kni/kni_fifo.h:64:
+ } while (unlikely(success == 0));
ERROR:TRAILING_WHITESPACE: trailing whitespace
#242: FILE: kernel/linux/kni/kni_fifo.h:65:
+ $
ERROR:CODE_INDENT: code indent should use tabs where possible
#242: FILE: kernel/linux/kni/kni_fifo.h:65:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#242: FILE: kernel/linux/kni/kni_fifo.h:65:
+ $
WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#246: FILE: kernel/linux/kni/kni_fifo.h:69:
+ for (i = 0; i < (n & ((~(unsigned int)0x3))); i += 4, idx += 4) {
ERROR:TRAILING_WHITESPACE: trailing whitespace
#249: FILE: kernel/linux/kni/kni_fifo.h:72:
+^I^I^Ififo->buffer[idx + 2] = data[i + 2]; $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#250: FILE: kernel/linux/kni/kni_fifo.h:73:
+^I^I^Ififo->buffer[idx + 3] = data[i + 3]; $
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#252: FILE: kernel/linux/kni/kni_fifo.h:75:
+ switch (n & 0x3) {
+ case 3:
[...]
+ case 2:
[...]
+ case 1:
ERROR:TRAILING_WHITESPACE: trailing whitespace
#259: FILE: kernel/linux/kni/kni_fifo.h:82:
+^I^I } $
WARNING:TABSTOP: Statements should start on a tabstop
#259: FILE: kernel/linux/kni/kni_fifo.h:82:
+ }
ERROR:TRAILING_WHITESPACE: trailing whitespace
#265: FILE: kernel/linux/kni/kni_fifo.h:87:
+ $
ERROR:CODE_INDENT: code indent should use tabs where possible
#265: FILE: kernel/linux/kni/kni_fifo.h:87:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#265: FILE: kernel/linux/kni/kni_fifo.h:87:
+ $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#275: FILE: kernel/linux/kni/kni_fifo.h:96:
+ $
ERROR:CODE_INDENT: code indent should use tabs where possible
#275: FILE: kernel/linux/kni/kni_fifo.h:96:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#275: FILE: kernel/linux/kni/kni_fifo.h:96:
+ $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#301: FILE: kernel/linux/kni/kni_fifo.h:117:
+{ $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#309: FILE: kernel/linux/kni/kni_fifo.h:125:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#309: FILE: kernel/linux/kni/kni_fifo.h:125:
+ $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#312: FILE: kernel/linux/kni/kni_fifo.h:128:
+ $
ERROR:CODE_INDENT: code indent should use tabs where possible
#312: FILE: kernel/linux/kni/kni_fifo.h:128:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#312: FILE: kernel/linux/kni/kni_fifo.h:128:
+ $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#314: FILE: kernel/linux/kni/kni_fifo.h:130:
+^Ido { $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#317: FILE: kernel/linux/kni/kni_fifo.h:133:
+ $
ERROR:CODE_INDENT: code indent should use tabs where possible
#317: FILE: kernel/linux/kni/kni_fifo.h:133:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#317: FILE: kernel/linux/kni/kni_fifo.h:133:
+ $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#320: FILE: kernel/linux/kni/kni_fifo.h:136:
+ $
ERROR:CODE_INDENT: code indent should use tabs where possible
#320: FILE: kernel/linux/kni/kni_fifo.h:136:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#320: FILE: kernel/linux/kni/kni_fifo.h:136:
+ $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#325: FILE: kernel/linux/kni/kni_fifo.h:141:
+^I^I */ $
WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#352: FILE: kernel/linux/kni/kni_fifo.h:160:
+ for (i = 0; i < (n & ((~(unsigned int)0x3))); i += 4, idx += 4) {
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#358: FILE: kernel/linux/kni/kni_fifo.h:166:
+ switch (n & 0x3) {
+ case 3:
[...]
+ case 2:
[...]
+ case 1:
WARNING:TABSTOP: Statements should start on a tabstop
#366: FILE: kernel/linux/kni/kni_fifo.h:174:
+ } else {
ERROR:CODE_INDENT: code indent should use tabs where possible
#369: FILE: kernel/linux/kni/kni_fifo.h:177:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#369: FILE: kernel/linux/kni/kni_fifo.h:177:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#372: FILE: kernel/linux/kni/kni_fifo.h:180:
+ mb();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#372: FILE: kernel/linux/kni/kni_fifo.h:180:
+ mb();$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#380: FILE: kernel/linux/kni/kni_fifo.h:188:
+ $
ERROR:CODE_INDENT: code indent should use tabs where possible
#380: FILE: kernel/linux/kni/kni_fifo.h:188:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#380: FILE: kernel/linux/kni/kni_fifo.h:188:
+ $
WARNING:BRACES: braces {} are not necessary for single statement blocks
#416: FILE: kernel/linux/kni/kni_misc.c:306:
+ if (!dev_info) {
+ return -ENOMEM;
+ }
ERROR:TRAILING_WHITESPACE: trailing whitespace
#566: FILE: kernel/linux/kni/kni_misc.c:407:
+^I$
WARNING:BRACES: braces {} are not necessary for single statement blocks
#660: FILE: kernel/linux/kni/kni_misc.c:487:
+ if (!dev_info) {
+ return -ENOMEM;
+ }
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1028: FILE: lib/librte_kni/rte_kni.c:145:
+kni_reserve_mz(struct rte_kni *kni, unsigned fifos_num)
WARNING:TABSTOP: Statements should start on a tabstop
#1070: FILE: lib/librte_kni/rte_kni.c:171:
+ for (i = 0; i < fifos_num; i++) {
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1359: FILE: lib/librte_kni/rte_kni.h:79:
+^Iunsigned int fifos_num; $
total: 29 errors, 19 warnings, 1307 lines checked
Warning in lib/librte_kni/rte_kni.c:
Declaring a variable inside for()
parent reply other threads:[~2020-12-10 16:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1607478454-23218-1-git-send-email-dheemanthm@vmware.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210162113.7C162BE73@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=dheemanthm@vmware.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).