From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 65599A04B5
	for <public@inbox.dpdk.org>; Sun, 13 Dec 2020 21:02:43 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 88BB7C97C;
	Sun, 13 Dec 2020 21:02:41 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id 8B66FC980; Sun, 13 Dec 2020 21:02:40 +0100 (CET)
In-Reply-To: <20201213200015.5932-1-talshn@nvidia.com>
References: <20201213200015.5932-1-talshn@nvidia.com>
To: test-report@dpdk.org
Cc: Tal Shnaiderman <talshn@nvidia.com>
Message-Id: <20201213200240.8B66FC980@dpdk.org>
Date: Sun, 13 Dec 2020 21:02:40 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw85081 [PATCH] eal/windows: add
	pthread TLS function support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/85081

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#78: FILE: lib/librte_eal/windows/include/pthread.h:186:
+		    __rte_unused void (*destructor)(void*))

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#80: FILE: lib/librte_eal/windows/include/pthread.h:188:
+	if (((*key) = TlsAlloc()) == TLS_OUT_OF_INDEXES) {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#82: FILE: lib/librte_eal/windows/include/pthread.h:190:
+		return ENOMEM;

total: 2 errors, 1 warnings, 54 lines checked