From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 355E7A09F6 for ; Fri, 18 Dec 2020 10:39:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C6EA7CA97; Fri, 18 Dec 2020 10:39:21 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 9B485CAB2; Fri, 18 Dec 2020 10:39:20 +0100 (CET) In-Reply-To: <20201218093702.3651867-15-jiawenwu@trustnetic.com> References: <20201218093702.3651867-15-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20201218093920.9B485CAB2@dpdk.org> Date: Fri, 18 Dec 2020 10:39:20 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw85421 [PATCH v3 14/33] net/txgbe: configure flow director filter X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/85421 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ipv6m' - possible side-effects? #174: FILE: drivers/net/txgbe/txgbe_fdir.c:19: +#define IPV6_ADDR_TO_MASK(ipaddr, ipv6m) do { \ + uint8_t ipv6_addr[16]; \ + uint8_t i; \ + rte_memcpy(ipv6_addr, (ipaddr), sizeof(ipv6_addr));\ + (ipv6m) = 0; \ + for (i = 0; i < sizeof(ipv6_addr); i++) { \ + if (ipv6_addr[i] == UINT8_MAX) \ + (ipv6m) |= 1 << i; \ + else if (ipv6_addr[i] != 0) { \ + PMD_DRV_LOG(ERR, " invalid IPv6 address mask."); \ + return -EINVAL; \ + } \ + } \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #174: FILE: drivers/net/txgbe/txgbe_fdir.c:19: +#define IPV6_ADDR_TO_MASK(ipaddr, ipv6m) do { \ + uint8_t ipv6_addr[16]; \ + uint8_t i; \ + rte_memcpy(ipv6_addr, (ipaddr), sizeof(ipv6_addr));\ + (ipv6m) = 0; \ + for (i = 0; i < sizeof(ipv6_addr); i++) { \ + if (ipv6_addr[i] == UINT8_MAX) \ + (ipv6m) |= 1 << i; \ + else if (ipv6_addr[i] != 0) { \ + PMD_DRV_LOG(ERR, " invalid IPv6 address mask."); \ + return -EINVAL; \ + } \ + } \ +} while (0) total: 0 errors, 1 warnings, 1 checks, 491 lines checked