From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BEC6A04B5 for ; Sat, 19 Dec 2020 09:08:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8E8DCB7F; Sat, 19 Dec 2020 09:08:00 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 41CE3CB69; Sat, 19 Dec 2020 09:08:00 +0100 (CET) In-Reply-To: <20201219075454.40266-3-jingjing.wu@intel.com> References: <20201219075454.40266-3-jingjing.wu@intel.com> To: test-report@dpdk.org Cc: Jingjing Wu Message-Id: <20201219080800.41CE3CB69@dpdk.org> Date: Sat, 19 Dec 2020 09:08:00 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw85502 [PATCH v1 2/5] net/iavf_be: control queue enabling X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/85502 _coding style issues_ WARNING:TYPO_SPELLING: 'implemention' may be misspelled - perhaps 'implementation'? #60: 2. Emu device callback functions implemention. ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #88: FILE: drivers/net/iavf_be/iavf_be.h:14: +#define IAVFBE_WRITE_32(addr, val) \ + *(volatile uint32_t *)(addr) = rte_cpu_to_le_32(val); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #88: FILE: drivers/net/iavf_be/iavf_be.h:14: +#define IAVFBE_WRITE_32(addr, val) \ + *(volatile uint32_t *)(addr) = rte_cpu_to_le_32(val); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around adapter->mem_table #208: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:148: + struct rte_iavf_emu_mem **mem = &(adapter->mem_table); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around adapter->mem_table #312: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:252: + struct rte_iavf_emu_mem **mem = &(adapter->mem_table); CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #388: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:328: + +} CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #413: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:353: + +} WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #500: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:481: + * done when emu device is ready.*/ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #607: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:74: + buf_va = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #673: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:140: + buf_va = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #732: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:199: + asq->ring = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #741: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:208: + arq->ring = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( WARNING:TYPO_SPELLING: 'initilized' may be misspelled - perhaps 'initialized'? #766: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:233: + /* Check if control queue is initilized */ WARNING:MISSING_SPACE: break quoted strings at a space character #784: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:251: + IAVF_BE_LOG(DEBUG, "Failed to read msg" + "from AdminQ"); total: 1 errors, 5 warnings, 8 checks, 713 lines checked Warning in drivers/net/iavf_be/iavf_be_ethdev.c: Using rte_atomicNN_xxx