From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C53CA04B5 for ; Sat, 19 Dec 2020 09:08:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 072A8CB76; Sat, 19 Dec 2020 09:08:10 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 80BCFCB47; Sat, 19 Dec 2020 09:08:09 +0100 (CET) In-Reply-To: <20201219075454.40266-4-jingjing.wu@intel.com> References: <20201219075454.40266-4-jingjing.wu@intel.com> To: test-report@dpdk.org Cc: Jingjing Wu Message-Id: <20201219080809.80BCFCB47@dpdk.org> Date: Sat, 19 Dec 2020 09:08:09 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw85503 [PATCH v1 3/5] net/iavf_be: virtchnl messages process X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/85503 _coding style issues_ WARNING:TYPO_SPELLING: 'implemention' may be misspelled - perhaps 'implementation'? #60: 2. Ethdev ops implemention for queues setup. WARNING:TYPO_SPELLING: 'queus' may be misspelled - perhaps 'queues'? #86: FILE: drivers/net/iavf_be/iavf_be.h:15: +/* Set the MAX vectors and queus to 16, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #241: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:129: + unsigned i; WARNING:TYPO_SPELLING: 'memeory' may be misspelled - perhaps 'memory'? #591: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:773: + IAVF_BE_LOG(ERR, "fail to allocate memeory for queue info"); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around adapter->mem_table #1025: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:205: + struct rte_iavf_emu_mem **mem = &(adapter->mem_table); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1234: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:414: + rxq->tx_ring = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon #1375: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:555: + adapter->eth_stats.tx_broadcast += rxq->stats.recv_broad_num;; WARNING:TYPO_SPELLING: 'Dont' may be misspelled - perhaps 'Don't'? #1390: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:570: + /* Dont add discards as recv count doesn't include this part */ CHECK:CAMELCASE: Avoid CamelCase: #1397: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:577: + IAVF_BE_LOG(DEBUG, "rx_bytes: %"PRIu64"", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1397: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:577: + IAVF_BE_LOG(DEBUG, "rx_bytes: %"PRIu64"", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1399: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:579: + IAVF_BE_LOG(DEBUG, "rx_unicast: %"PRIu64"", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1401: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:581: + IAVF_BE_LOG(DEBUG, "rx_multicast: %"PRIu64"", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1403: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:583: + IAVF_BE_LOG(DEBUG, "rx_broadcast: %"PRIu64"", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1405: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:585: + IAVF_BE_LOG(DEBUG, "rx_discards: %"PRIu64"", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1408: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:588: + IAVF_BE_LOG(DEBUG, "tx_bytes: %"PRIu64"", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1410: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:590: + IAVF_BE_LOG(DEBUG, "tx_unicast: %"PRIu64"", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1412: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:592: + IAVF_BE_LOG(DEBUG, "tx_multicast: %"PRIu64"", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1414: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:594: + IAVF_BE_LOG(DEBUG, "tx_broadcast: %"PRIu64"", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1416: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:596: + IAVF_BE_LOG(DEBUG, "tx_discards: %"PRIu64"", WARNING:BRACES: braces {} are not necessary for single statement blocks #1536: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:782: + for (i = 0; i < addr_list->num_elements; i++) { + + /* TODO: mac filter havn't been enabled yet */ + + } CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #1537: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:783: + for (i = 0; i < addr_list->num_elements; i++) { + WARNING:TYPO_SPELLING: 'havn't' may be misspelled - perhaps 'haven't'? #1538: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:784: + /* TODO: mac filter havn't been enabled yet */ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1540: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:786: + + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1563: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:809: + for (i = 0; i < addr_list->num_elements; i++) { + + /* TODO: mac filter havn't been enabled yet */ + + } CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #1564: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:810: + for (i = 0; i < addr_list->num_elements; i++) { + WARNING:TYPO_SPELLING: 'havn't' may be misspelled - perhaps 'haven't'? #1565: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:811: + /* TODO: mac filter havn't been enabled yet */ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1567: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:813: + + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1589: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:835: + for (i = 0; i < vlan_list->num_elements; i++) { + + /* TODO: vlan filter havn't been enabled yet */ + + } CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #1590: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:836: + for (i = 0; i < vlan_list->num_elements; i++) { + WARNING:TYPO_SPELLING: 'havn't' may be misspelled - perhaps 'haven't'? #1591: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:837: + /* TODO: vlan filter havn't been enabled yet */ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1593: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:839: + + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1616: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:862: + for (i = 0; i < vlan_list->num_elements; i++) { + + /* TODO: vlan filter havn't been enabled yet */ + + } CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #1617: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:863: + for (i = 0; i < vlan_list->num_elements; i++) { + WARNING:TYPO_SPELLING: 'havn't' may be misspelled - perhaps 'haven't'? #1618: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:864: + /* TODO: vlan filter havn't been enabled yet */ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1620: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:866: + + } CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1635: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:881: + msg_opc = (enum virtchnl_ops)rte_le_to_cpu_32( CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1732: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:978: + +} total: 0 errors, 14 warnings, 23 checks, 1629 lines checked Warning in drivers/net/iavf_be/iavf_be_ethdev.c: Using rte_atomicNN_xxx