From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24DE0A04B5 for ; Sat, 19 Dec 2020 09:08:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BAACCB69; Sat, 19 Dec 2020 09:08:14 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 4340ECB2F; Sat, 19 Dec 2020 09:08:13 +0100 (CET) In-Reply-To: <20201219075454.40266-5-jingjing.wu@intel.com> References: <20201219075454.40266-5-jingjing.wu@intel.com> To: test-report@dpdk.org Cc: Jingjing Wu Message-Id: <20201219080813.4340ECB2F@dpdk.org> Date: Sat, 19 Dec 2020 09:08:13 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw85504 [PATCH v1 4/5] net/iavf_be: add Rx Tx burst support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/85504 _coding style issues_ WARNING:MASK_THEN_SHIFT: Possible precedence defect with mask then right shift - may need parentheses #97: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:168: + m->l2_len = offset & IAVF_TXD_QW1_MACLEN_MASK >> WARNING:MASK_THEN_SHIFT: Possible precedence defect with mask then right shift - may need parentheses #99: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:170: + m->l3_len = offset & IAVF_TXD_QW1_IPLEN_MASK >> WARNING:MASK_THEN_SHIFT: Possible precedence defect with mask then right shift - may need parentheses #101: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:172: + m->l4_len = offset & IAVF_TXD_QW1_L4LEN_MASK >> WARNING:BRACES: braces {} are not necessary for single statement blocks #170: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:241: + if ((head & 0x3) == 0) { + rte_prefetch0(&ring_dma[head]); + } CHECK:SPACING: spaces preferred around that '&' (ctx:WxV) #185: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:256: + cmd = (d->cmd_type_offset_bsz &IAVF_TXD_QW1_CMD_MASK) >> ^ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #205: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:276: + desc_addr = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'first->pkt_len > rxq->max_pkt_len' #249: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:320: + if ((!(ol_flags & PKT_TX_TCP_SEG)) && + (first->pkt_len > rxq->max_pkt_len)) { CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #318: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:389: + desc_addr = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( CHECK:CAMELCASE: Avoid CamelCase: #443: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:116: + printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64 CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #443: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:116: + printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64 CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #444: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:117: + " QW2: 0x%016"PRIx64" QW3: 0x%016"PRIx64" ", txq->queue_id, CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #460: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:133: + type = (enum iavf_tx_desc_dtype_value)rte_le_to_cpu_64( CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #475: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:148: + printf("Queue %d %s %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64" ", total: 0 errors, 4 warnings, 9 checks, 406 lines checked Warning in drivers/net/iavf_be/iavf_be_rxtx.c: Using rte_atomicNN_xxx