From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tal Shnaiderman <talshn@nvidia.com>
Subject: [dpdk-test-report] |WARNING| pw85738 [PATCH] mlx5: split multi-threaded flows per OS
Date: Sat, 26 Dec 2020 17:58:51 +0100 (CET) [thread overview]
Message-ID: <20201226165851.A137C69FB@dpdk.org> (raw)
In-Reply-To: <20201226165714.4416-1-talshn@nvidia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/85738
_coding style issues_
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#101: FILE: drivers/net/mlx5/linux/mlx5_flow_os.c:17:
+ return ENOMEM;
CHECK:CAMELCASE: Avoid CamelCase: <WaitForSingleObject>
#286: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:261:
+ DWORD result = WaitForSingleObject(thread_handle, 0);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#288: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:263:
+ if (result == WAIT_OBJECT_0) {
+ return false;
+ }
CHECK:CAMELCASE: Avoid CamelCase: <DuplicateHandle>
#297: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:272:
+ BOOL ret = DuplicateHandle(GetCurrentProcess(), GetCurrentThread(),
CHECK:CAMELCASE: Avoid CamelCase: <GetCurrentProcess>
#297: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:272:
+ BOOL ret = DuplicateHandle(GetCurrentProcess(), GetCurrentThread(),
CHECK:CAMELCASE: Avoid CamelCase: <GetCurrentThread>
#297: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:272:
+ BOOL ret = DuplicateHandle(GetCurrentProcess(), GetCurrentThread(),
CHECK:CAMELCASE: Avoid CamelCase: <CloseHandle>
#333: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:308:
+ CloseHandle(temp->thread_handle);
CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#384: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:359:
+ first = curr = temp;
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#386: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:361:
+ }
+ else {
CHECK:BRACES: Unbalanced braces around else statement
#386: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:361:
+ else {
total: 1 errors, 2 warnings, 7 checks, 333 lines checked
parent reply other threads:[~2020-12-26 16:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201226165714.4416-1-talshn@nvidia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201226165851.A137C69FB@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=talshn@nvidia.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).