From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jingjing Wu <jingjing.wu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw86086 [PATCH v2 2/6] net/iavf_be: control queue enabling
Date: Thu, 7 Jan 2021 08:29:44 +0100 (CET) [thread overview]
Message-ID: <20210107072944.591E32B9D@dpdk.org> (raw)
In-Reply-To: <20210107071503.14720-3-jingjing.wu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/86086
_coding style issues_
WARNING:TYPO_SPELLING: 'implemention' may be misspelled - perhaps 'implementation'?
#61:
2. Emu device callback functions implemention.
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#88: FILE: drivers/net/iavf_be/iavf_be.h:13:
+#define IAVFBE_WRITE_32(addr, val) \
+ *(volatile uint32_t *)(addr) = rte_cpu_to_le_32(val);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#88: FILE: drivers/net/iavf_be/iavf_be.h:13:
+#define IAVFBE_WRITE_32(addr, val) \
+ *(volatile uint32_t *)(addr) = rte_cpu_to_le_32(val);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around adapter->mem_table
#208: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:148:
+ struct rte_iavf_emu_mem **mem = &(adapter->mem_table);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around adapter->mem_table
#312: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:252:
+ struct rte_iavf_emu_mem **mem = &(adapter->mem_table);
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#388: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:328:
+
+}
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#413: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:353:
+
+}
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#500: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:481:
+ * done when emu device is ready.*/
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#619: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:86:
+ buf_va = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#687: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:154:
+ buf_va = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#746: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:213:
+ asq->ring = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#755: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:222:
+ arq->ring = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr(
WARNING:TYPO_SPELLING: 'initilized' may be misspelled - perhaps 'initialized'?
#780: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:247:
+ /* Check if control queue is initilized */
WARNING:MISSING_SPACE: break quoted strings at a space character
#798: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:265:
+ IAVF_BE_LOG(DEBUG, "Failed to read msg"
+ "from AdminQ");
total: 1 errors, 5 warnings, 8 checks, 726 lines checked
Warning in drivers/net/iavf_be/iavf_be_ethdev.c:
Using rte_atomicNN_xxx
parent reply other threads:[~2021-01-07 7:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210107071503.14720-3-jingjing.wu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107072944.591E32B9D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).