From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jingjing Wu <jingjing.wu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw86088 [PATCH v2 4/6] net/iavf_be: add Rx Tx burst support
Date: Thu, 7 Jan 2021 08:29:57 +0100 (CET) [thread overview]
Message-ID: <20210107072957.6DB952B9D@dpdk.org> (raw)
In-Reply-To: <20210107071503.14720-5-jingjing.wu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/86088
_coding style issues_
WARNING:MASK_THEN_SHIFT: Possible precedence defect with mask then right shift - may need parentheses
#98: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:170:
+ m->l2_len = offset & IAVF_TXD_QW1_MACLEN_MASK >>
WARNING:MASK_THEN_SHIFT: Possible precedence defect with mask then right shift - may need parentheses
#100: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:172:
+ m->l3_len = offset & IAVF_TXD_QW1_IPLEN_MASK >>
WARNING:MASK_THEN_SHIFT: Possible precedence defect with mask then right shift - may need parentheses
#102: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:174:
+ m->l4_len = offset & IAVF_TXD_QW1_L4LEN_MASK >>
WARNING:BRACES: braces {} are not necessary for single statement blocks
#173: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:245:
+ if ((head & 0x3) == 0) {
+ rte_prefetch0(&ring_dma[head]);
+ }
CHECK:SPACING: spaces preferred around that '&' (ctx:WxV)
#190: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:262:
+ cmd = (d->cmd_type_offset_bsz &IAVF_TXD_QW1_CMD_MASK) >>
^
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#210: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:282:
+ desc_addr = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'first->pkt_len > rxq->max_pkt_len'
#254: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:326:
+ if ((!(ol_flags & PKT_TX_TCP_SEG)) &&
+ (first->pkt_len > rxq->max_pkt_len)) {
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#329: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:401:
+ desc_addr = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr(
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#457: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:118:
+ printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#457: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:118:
+ printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#458: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:119:
+ " QW2: 0x%016"PRIx64" QW3: 0x%016"PRIx64"
", txq->queue_id,
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#474: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:135:
+ type = (enum iavf_tx_desc_dtype_value)rte_le_to_cpu_64(
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#489: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:150:
+ printf("Queue %d %s %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64"
",
total: 0 errors, 4 warnings, 9 checks, 419 lines checked
Warning in drivers/net/iavf_be/iavf_be_rxtx.c:
Using rte_atomicNN_xxx
parent reply other threads:[~2021-01-07 7:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210107071503.14720-5-jingjing.wu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107072957.6DB952B9D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).