From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54549A09FF for ; Thu, 7 Jan 2021 08:29:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F6E2140E9D; Thu, 7 Jan 2021 08:29:58 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mails.dpdk.org (Postfix) with ESMTP id 71B8B140D04 for ; Thu, 7 Jan 2021 08:29:57 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 6DB952B9D; Thu, 7 Jan 2021 08:29:57 +0100 (CET) In-Reply-To: <20210107071503.14720-5-jingjing.wu@intel.com> References: <20210107071503.14720-5-jingjing.wu@intel.com> To: test-report@dpdk.org Cc: Jingjing Wu Message-Id: <20210107072957.6DB952B9D@dpdk.org> Date: Thu, 7 Jan 2021 08:29:57 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw86088 [PATCH v2 4/6] net/iavf_be: add Rx Tx burst support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/86088 _coding style issues_ WARNING:MASK_THEN_SHIFT: Possible precedence defect with mask then right shift - may need parentheses #98: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:170: + m->l2_len = offset & IAVF_TXD_QW1_MACLEN_MASK >> WARNING:MASK_THEN_SHIFT: Possible precedence defect with mask then right shift - may need parentheses #100: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:172: + m->l3_len = offset & IAVF_TXD_QW1_IPLEN_MASK >> WARNING:MASK_THEN_SHIFT: Possible precedence defect with mask then right shift - may need parentheses #102: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:174: + m->l4_len = offset & IAVF_TXD_QW1_L4LEN_MASK >> WARNING:BRACES: braces {} are not necessary for single statement blocks #173: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:245: + if ((head & 0x3) == 0) { + rte_prefetch0(&ring_dma[head]); + } CHECK:SPACING: spaces preferred around that '&' (ctx:WxV) #190: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:262: + cmd = (d->cmd_type_offset_bsz &IAVF_TXD_QW1_CMD_MASK) >> ^ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #210: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:282: + desc_addr = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'first->pkt_len > rxq->max_pkt_len' #254: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:326: + if ((!(ol_flags & PKT_TX_TCP_SEG)) && + (first->pkt_len > rxq->max_pkt_len)) { CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #329: FILE: drivers/net/iavf_be/iavf_be_rxtx.c:401: + desc_addr = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( CHECK:CAMELCASE: Avoid CamelCase: #457: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:118: + printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64 CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #457: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:118: + printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64 CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #458: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:119: + " QW2: 0x%016"PRIx64" QW3: 0x%016"PRIx64" ", txq->queue_id, CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #474: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:135: + type = (enum iavf_tx_desc_dtype_value)rte_le_to_cpu_64( CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #489: FILE: drivers/net/iavf_be/iavf_be_rxtx.h:150: + printf("Queue %d %s %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64" ", total: 0 errors, 4 warnings, 9 checks, 419 lines checked Warning in drivers/net/iavf_be/iavf_be_rxtx.c: Using rte_atomicNN_xxx