From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E38A2A09FF
	for <public@inbox.dpdk.org>; Thu,  7 Jan 2021 09:00:08 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DFA4D140EDA;
	Thu,  7 Jan 2021 09:00:08 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.14.124])
 by mails.dpdk.org (Postfix) with ESMTP id 97BF3140EDA
 for <test-report@dpdk.org>; Thu,  7 Jan 2021 09:00:07 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id 7AB092B9D; Thu,  7 Jan 2021 09:00:07 +0100 (CET)
In-Reply-To: <20210107074533.15465-2-jingjing.wu@intel.com>
References: <20210107074533.15465-2-jingjing.wu@intel.com>
To: test-report@dpdk.org
Cc: Jingjing Wu <jingjing.wu@intel.com>
Message-Id: <20210107080007.7AB092B9D@dpdk.org>
Date: Thu,  7 Jan 2021 09:00:07 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw86092 [PATCH v2 1/4]
 net/iavf_client: introduce iavf driver on vfio-user client
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/86092

_coding style issues_


WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#192: FILE: drivers/net/iavf/iavf_client_ethdev.c:27:
+static const char *valid_args[] = {

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#228: FILE: drivers/net/iavf/iavf_client_ethdev.c:63:
+
+	}

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#295: FILE: drivers/net/iavf/iavf_client_ethdev.c:130:
+	eth_dev->data->mac_addrs = rte_zmalloc(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#307: FILE: drivers/net/iavf/iavf_client_ethdev.c:142:
+	if (!rte_is_valid_assigned_ether_addr(

WARNING:BRACES: braces {} are not necessary for single statement blocks
#409: FILE: drivers/net/iavf/iavf_client_ethdev.c:244:
+	if (ret) {
+		goto err;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#414: FILE: drivers/net/iavf/iavf_client_ethdev.c:249:
+	if (ret) {
+		goto err;
+	}

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#543: FILE: drivers/net/iavf/iavf_rxtx.c:604:
+		rxq->qrx_tail = client_vfio_user_get_bar_addr(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#559: FILE: drivers/net/iavf/iavf_rxtx.c:721:
+		txq->qtx_tail = client_vfio_user_get_bar_addr(

total: 0 errors, 3 warnings, 5 checks, 444 lines checked