From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jingjing Wu <jingjing.wu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw86115 [PATCH v3 2/5] net/iavf_client: introduce iavf driver on vfio-user client
Date: Thu, 7 Jan 2021 09:42:54 +0100 (CET) [thread overview]
Message-ID: <20210107084254.CF0342BAA@dpdk.org> (raw)
In-Reply-To: <20210107082718.33748-3-jingjing.wu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/86115
_coding style issues_
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#192: FILE: drivers/net/iavf/iavf_client_ethdev.c:27:
+static const char *valid_args[] = {
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#228: FILE: drivers/net/iavf/iavf_client_ethdev.c:63:
+
+ }
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#295: FILE: drivers/net/iavf/iavf_client_ethdev.c:130:
+ eth_dev->data->mac_addrs = rte_zmalloc(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#307: FILE: drivers/net/iavf/iavf_client_ethdev.c:142:
+ if (!rte_is_valid_assigned_ether_addr(
WARNING:BRACES: braces {} are not necessary for single statement blocks
#409: FILE: drivers/net/iavf/iavf_client_ethdev.c:244:
+ if (ret) {
+ goto err;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#414: FILE: drivers/net/iavf/iavf_client_ethdev.c:249:
+ if (ret) {
+ goto err;
+ }
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#543: FILE: drivers/net/iavf/iavf_rxtx.c:604:
+ rxq->qrx_tail = client_vfio_user_get_bar_addr(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#559: FILE: drivers/net/iavf/iavf_rxtx.c:721:
+ txq->qtx_tail = client_vfio_user_get_bar_addr(
total: 0 errors, 3 warnings, 5 checks, 444 lines checked
parent reply other threads:[~2021-01-07 8:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210107082718.33748-3-jingjing.wu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107084254.CF0342BAA@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).