From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66BF3A0A0A for ; Fri, 22 Jan 2021 10:50:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B4E7140F1D; Fri, 22 Jan 2021 10:50:59 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mails.dpdk.org (Postfix) with ESMTP id A5C07140F1C for ; Fri, 22 Jan 2021 10:50:58 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 9B86BF3E; Fri, 22 Jan 2021 10:50:58 +0100 (CET) In-Reply-To: <20210122094800.197748-9-jiawenwu@trustnetic.com> References: <20210122094800.197748-9-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20210122095058.9B86BF3E@dpdk.org> Date: Fri, 22 Jan 2021 10:50:58 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw87066 [PATCH v1 08/20] net/txgbe: add VF device stats and xstats get operation X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/87066 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects? #94: FILE: drivers/net/txgbe/base/txgbe_regs.h:1704: +#define TXGBE_UPDCNT32(reg, last, cur) \ +do { \ + uint32_t latest = rd32(hw, reg); \ + if (hw->offset_loaded || hw->rx_loaded) \ + last = 0; \ + cur += (latest - last) & UINT_MAX; \ + last = latest; \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues #94: FILE: drivers/net/txgbe/base/txgbe_regs.h:1704: +#define TXGBE_UPDCNT32(reg, last, cur) \ +do { \ + uint32_t latest = rd32(hw, reg); \ + if (hw->offset_loaded || hw->rx_loaded) \ + last = 0; \ + cur += (latest - last) & UINT_MAX; \ + last = latest; \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'regl' - possible side-effects? #103: FILE: drivers/net/txgbe/base/txgbe_regs.h:1713: +#define TXGBE_UPDCNT36(regl, last, cur) \ +do { \ + uint64_t new_lsb = rd32(hw, regl); \ + uint64_t new_msb = rd32(hw, regl + 4); \ + uint64_t latest = ((new_msb << 32) | new_lsb); \ + if (hw->offset_loaded || hw->rx_loaded) \ + last = 0; \ + cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \ + last = latest; \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects? #103: FILE: drivers/net/txgbe/base/txgbe_regs.h:1713: +#define TXGBE_UPDCNT36(regl, last, cur) \ +do { \ + uint64_t new_lsb = rd32(hw, regl); \ + uint64_t new_msb = rd32(hw, regl + 4); \ + uint64_t latest = ((new_msb << 32) | new_lsb); \ + if (hw->offset_loaded || hw->rx_loaded) \ + last = 0; \ + cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \ + last = latest; \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues #103: FILE: drivers/net/txgbe/base/txgbe_regs.h:1713: +#define TXGBE_UPDCNT36(regl, last, cur) \ +do { \ + uint64_t new_lsb = rd32(hw, regl); \ + uint64_t new_msb = rd32(hw, regl + 4); \ + uint64_t latest = ((new_msb << 32) | new_lsb); \ + if (hw->offset_loaded || hw->rx_loaded) \ + last = 0; \ + cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \ + last = latest; \ +} while (0) total: 0 errors, 0 warnings, 5 checks, 264 lines checked