From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Rasesh Mody <rmody@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw88008 [PATCH 5/7] net/qede: changes for DMA page chain allocation and free
Date: Fri, 19 Feb 2021 11:16:28 +0100 (CET) [thread overview]
Message-ID: <20210219101628.3055FC966@dpdk.org> (raw)
In-Reply-To: <20210219101422.19121-6-rmody@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/88008
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'elem_size' - possible side-effects?
#274: FILE: drivers/net/qede/base/ecore_chain.h:173:
+#define USABLE_ELEMS_PER_PAGE(elem_size, page_size, mode) \
+ ((u32)(ELEMS_PER_PAGE(page_size, elem_size) - \
+ UNUSABLE_ELEMS_PER_PAGE(elem_size, mode)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#392: FILE: drivers/net/qede/base/ecore_chain.h:383:
+#define test_and_skip(p, idx) \
+ do { \
+ if (is_chain_u16(p)) { \
+ if (is_unusable_idx(p, idx)) \
+ (p)->u.chain16.idx += (p)->elem_unusable; \
+ } else { \
+ if (is_unusable_idx_u32(p, idx)) \
+ (p)->u.chain32.idx += (p)->elem_unusable; \
+ } \
} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#392: FILE: drivers/net/qede/base/ecore_chain.h:383:
+#define test_and_skip(p, idx) \
+ do { \
+ if (is_chain_u16(p)) { \
+ if (is_unusable_idx(p, idx)) \
+ (p)->u.chain16.idx += (p)->elem_unusable; \
+ } else { \
+ if (is_unusable_idx_u32(p, idx)) \
+ (p)->u.chain32.idx += (p)->elem_unusable; \
+ } \
} while (0)
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#701: FILE: drivers/net/qede/base/ecore_dev.c:7857:
+ "The actual chain size (0x%" PRIx64 ") is larger than the maximal possible value
",
total: 0 errors, 0 warnings, 4 checks, 975 lines checked
parent reply other threads:[~2021-02-19 10:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210219101422.19121-6-rmody@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219101628.3055FC966@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=rmody@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).