From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EFD86A0548
	for <public@inbox.dpdk.org>; Sat,  6 Mar 2021 16:38:11 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DF8D122A3CE;
	Sat,  6 Mar 2021 16:38:11 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.14.124])
 by mails.dpdk.org (Postfix) with ESMTP id A959822A391
 for <test-report@dpdk.org>; Sat,  6 Mar 2021 16:38:10 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id A3D352B9D; Sat,  6 Mar 2021 16:38:10 +0100 (CET)
In-Reply-To: <20210306153404.10781-22-ndabilpuram@marvell.com>
References: <20210306153404.10781-22-ndabilpuram@marvell.com>
To: test-report@dpdk.org
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>
Message-Id: <20210306153810.A3D352B9D@dpdk.org>
Date: Sat,  6 Mar 2021 16:38:10 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw88618 [PATCH 21/44] net/cnxk: add Tx
 multi-segment version for cn10k
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/88618

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flags' - possible side-effects?
#195: FILE: drivers/net/cnxk/cn10k_tx.c:237:
+#define T(name, f4, f3, f2, f1, f0, sz, flags)				       \
+	static uint16_t __rte_noinline __rte_hot                               \
+		cn10k_nix_xmit_pkts_mseg_##name(void *tx_queue,                \
+						struct rte_mbuf **tx_pkts,     \
+						uint16_t pkts)                 \
+	{                                                                      \
+		uint64_t cmd[(sz)];                                            \
+									       \
+		/* For TSO inner checksum is a must */                         \
+		if (((flags) & NIX_TX_OFFLOAD_TSO_F) &&			       \
+		    !((flags) & NIX_TX_OFFLOAD_L3_L4_CSUM_F))		       \
+			return 0;                                              \
+		return nix_xmit_pkts_mseg(tx_queue, tx_pkts, pkts, cmd,        \
+					  (flags) | NIX_TX_MULTI_SEG_F);       \
+	}

total: 0 errors, 0 warnings, 1 checks, 226 lines checked