From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4BCAA054F for ; Mon, 15 Mar 2021 15:00:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8F202426A0; Mon, 15 Mar 2021 15:00:12 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mails.dpdk.org (Postfix) with ESMTP id 40AA2242690 for ; Mon, 15 Mar 2021 15:00:09 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 2A73A58CD; Mon, 15 Mar 2021 15:00:09 +0100 (CET) In-Reply-To: <20210315135823.605774-3-andrew.rybchenko@oktetlabs.ru> References: <20210315135823.605774-3-andrew.rybchenko@oktetlabs.ru> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20210315140009.2A73A58CD@dpdk.org> Date: Mon, 15 Mar 2021 15:00:09 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw89125 [PATCH v2 2/8] common/sfc_efx/base: add API to get VirtQ doorbell offset X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/89125 _coding style issues_ WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #93: FILE: drivers/common/sfc_efx/base/efx.h:4488: + __out uint32_t *offsetp); WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_t *' should also have an identifier name #106: FILE: drivers/common/sfc_efx/base/efx_impl.h:319: + efx_rc_t (*evo_get_doorbell_offset)(efx_virtio_vq_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name #106: FILE: drivers/common/sfc_efx/base/efx_impl.h:319: + efx_rc_t (*evo_get_doorbell_offset)(efx_virtio_vq_t *, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #130: FILE: drivers/common/sfc_efx/base/efx_virtio.c:220: + __out uint32_t *offsetp) WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #136: FILE: drivers/common/sfc_efx/base/efx_virtio.c:226: + if ((evvp == NULL) || (offsetp == NULL)) { WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #152: FILE: drivers/common/sfc_efx/base/efx_virtio.c:242: + if ((rc = evop->evo_get_doorbell_offset(evvp, offsetp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #152: FILE: drivers/common/sfc_efx/base/efx_virtio.c:242: + if ((rc = evop->evo_get_doorbell_offset(evvp, offsetp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #155: FILE: drivers/common/sfc_efx/base/efx_virtio.c:245: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #164: FILE: drivers/common/sfc_efx/base/efx_virtio.c:254: + return (rc); WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #180: FILE: drivers/common/sfc_efx/base/rhead_impl.h:499: + __out uint32_t *offsetp); WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #196: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:193: + __out uint32_t *offsetp) WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #247: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:244: + *offsetp = MCDI_OUT_DWORD(req, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #250: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:247: + *offsetp = MCDI_OUT_DWORD(req, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #261: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:258: + *offsetp = MCDI_OUT_DWORD(req, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #283: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:280: + return (rc); total: 4 errors, 11 warnings, 186 lines checked