From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49691A054F for ; Mon, 15 Mar 2021 15:01:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AE13242675; Mon, 15 Mar 2021 15:01:55 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mails.dpdk.org (Postfix) with ESMTP id 95FC624266A for ; Mon, 15 Mar 2021 15:01:53 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 818E3100C; Mon, 15 Mar 2021 15:01:53 +0100 (CET) In-Reply-To: <20210315135823.605774-2-andrew.rybchenko@oktetlabs.ru> References: <20210315135823.605774-2-andrew.rybchenko@oktetlabs.ru> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20210315140153.818E3100C@dpdk.org> Date: Mon, 15 Mar 2021 15:01:53 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw89126 [PATCH v2 1/8] common/sfc_efx/base: add base virtio support for vDPA X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/89126 _coding style issues_ WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_t *' should also have an identifier name #235: FILE: drivers/common/sfc_efx/base/efx_impl.h:314: + efx_rc_t (*evo_virtio_qstart)(efx_virtio_vq_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_cfg_t *' should also have an identifier name #235: FILE: drivers/common/sfc_efx/base/efx_impl.h:314: + efx_rc_t (*evo_virtio_qstart)(efx_virtio_vq_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_dyncfg_t *' should also have an identifier name #235: FILE: drivers/common/sfc_efx/base/efx_impl.h:314: + efx_rc_t (*evo_virtio_qstart)(efx_virtio_vq_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_t *' should also have an identifier name #238: FILE: drivers/common/sfc_efx/base/efx_impl.h:317: + efx_rc_t (*evo_virtio_qstop)(efx_virtio_vq_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_dyncfg_t *' should also have an identifier name #238: FILE: drivers/common/sfc_efx/base/efx_impl.h:317: + efx_rc_t (*evo_virtio_qstop)(efx_virtio_vq_t *, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #335: FILE: drivers/common/sfc_efx/base/efx_virtio.c:45: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #343: FILE: drivers/common/sfc_efx/base/efx_virtio.c:53: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #371: FILE: drivers/common/sfc_efx/base/efx_virtio.c:81: + EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (efx_virtio_vq_t), evvp); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #383: FILE: drivers/common/sfc_efx/base/efx_virtio.c:93: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #388: FILE: drivers/common/sfc_efx/base/efx_virtio.c:98: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #416: FILE: drivers/common/sfc_efx/base/efx_virtio.c:126: + if ((rc = evop->evo_virtio_qstart(evvp, evvcp, evvdp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #423: FILE: drivers/common/sfc_efx/base/efx_virtio.c:133: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #434: FILE: drivers/common/sfc_efx/base/efx_virtio.c:144: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #468: FILE: drivers/common/sfc_efx/base/efx_virtio.c:178: + if ((rc = evop->evo_virtio_qstop(evvp, evvdp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #484: FILE: drivers/common/sfc_efx/base/efx_virtio.c:194: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #502: FILE: drivers/common/sfc_efx/base/efx_virtio.c:212: + EFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_virtio_vq_t), evvp); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #684: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:124: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #695: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:135: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #747: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:187: + return (rc); total: 12 errors, 7 warnings, 636 lines checked