From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 69F5EA054F
	for <public@inbox.dpdk.org>; Mon, 15 Mar 2021 15:01:59 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6601D242679;
	Mon, 15 Mar 2021 15:01:59 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.14.124])
 by mails.dpdk.org (Postfix) with ESMTP id 80DDF24267F
 for <test-report@dpdk.org>; Mon, 15 Mar 2021 15:01:57 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id 79DB658CD; Mon, 15 Mar 2021 15:01:57 +0100 (CET)
In-Reply-To: <20210315135823.605774-5-andrew.rybchenko@oktetlabs.ru>
References: <20210315135823.605774-5-andrew.rybchenko@oktetlabs.ru>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-Id: <20210315140157.79DB658CD@dpdk.org>
Date: Mon, 15 Mar 2021 15:01:57 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw89128 [PATCH v2 4/8]
 common/sfc_efx/base: add support to get virtio features
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89128

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#113: FILE: drivers/common/sfc_efx/base/efx_impl.h:321:
+	efx_rc_t	(*evo_get_features)(efx_nic_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_device_type_t' should also have an identifier name
#113: FILE: drivers/common/sfc_efx/base/efx_impl.h:321:
+	efx_rc_t	(*evo_get_features)(efx_nic_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t *' should also have an identifier name
#113: FILE: drivers/common/sfc_efx/base/efx_impl.h:321:
+	efx_rc_t	(*evo_get_features)(efx_nic_t *,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#161: FILE: drivers/common/sfc_efx/base/efx_virtio.c:285:
+	if ((rc = evop->evo_get_features(enp, type, featuresp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#164: FILE: drivers/common/sfc_efx/base/efx_virtio.c:288:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#175: FILE: drivers/common/sfc_efx/base/efx_virtio.c:299:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#247: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:325:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#254: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:332:
+	return (rc);

total: 5 errors, 3 warnings, 158 lines checked