From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [dpdk-test-report] |WARNING| pw89176 [PATCH v3 1/8] common/sfc_efx/base: add base virtio support for vDPA
Date: Tue, 16 Mar 2021 07:17:11 +0100 (CET) [thread overview]
Message-ID: <20210316061711.CA20B2BF4@dpdk.org> (raw)
In-Reply-To: <20210316061544.861619-2-andrew.rybchenko@oktetlabs.ru>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89176
_coding style issues_
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_t *' should also have an identifier name
#235: FILE: drivers/common/sfc_efx/base/efx_impl.h:314:
+ efx_rc_t (*evo_virtio_qstart)(efx_virtio_vq_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_cfg_t *' should also have an identifier name
#235: FILE: drivers/common/sfc_efx/base/efx_impl.h:314:
+ efx_rc_t (*evo_virtio_qstart)(efx_virtio_vq_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_dyncfg_t *' should also have an identifier name
#235: FILE: drivers/common/sfc_efx/base/efx_impl.h:314:
+ efx_rc_t (*evo_virtio_qstart)(efx_virtio_vq_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_t *' should also have an identifier name
#238: FILE: drivers/common/sfc_efx/base/efx_impl.h:317:
+ efx_rc_t (*evo_virtio_qstop)(efx_virtio_vq_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_dyncfg_t *' should also have an identifier name
#238: FILE: drivers/common/sfc_efx/base/efx_impl.h:317:
+ efx_rc_t (*evo_virtio_qstop)(efx_virtio_vq_t *,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#335: FILE: drivers/common/sfc_efx/base/efx_virtio.c:45:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#343: FILE: drivers/common/sfc_efx/base/efx_virtio.c:53:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#371: FILE: drivers/common/sfc_efx/base/efx_virtio.c:81:
+ EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (efx_virtio_vq_t), evvp);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#383: FILE: drivers/common/sfc_efx/base/efx_virtio.c:93:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#388: FILE: drivers/common/sfc_efx/base/efx_virtio.c:98:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#416: FILE: drivers/common/sfc_efx/base/efx_virtio.c:126:
+ if ((rc = evop->evo_virtio_qstart(evvp, evvcp, evvdp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#423: FILE: drivers/common/sfc_efx/base/efx_virtio.c:133:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#434: FILE: drivers/common/sfc_efx/base/efx_virtio.c:144:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#468: FILE: drivers/common/sfc_efx/base/efx_virtio.c:178:
+ if ((rc = evop->evo_virtio_qstop(evvp, evvdp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#484: FILE: drivers/common/sfc_efx/base/efx_virtio.c:194:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#502: FILE: drivers/common/sfc_efx/base/efx_virtio.c:212:
+ EFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_virtio_vq_t), evvp);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#684: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:124:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#695: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:135:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#747: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:187:
+ return (rc);
total: 12 errors, 7 warnings, 636 lines checked
parent reply other threads:[~2021-03-16 6:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210316061544.861619-2-andrew.rybchenko@oktetlabs.ru>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316061711.CA20B2BF4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).