automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw89199 [PATCH v4 4/8] common/sfc_efx/base: add support to get virtio features
       [not found] <20210316085832.942481-5-andrew.rybchenko@oktetlabs.ru>
@ 2021-03-16  8:59 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-03-16  8:59 UTC (permalink / raw)
  To: test-report; +Cc: Andrew Rybchenko

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89199

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#113: FILE: drivers/common/sfc_efx/base/efx_impl.h:321:
+	efx_rc_t	(*evo_get_features)(efx_nic_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_device_type_t' should also have an identifier name
#113: FILE: drivers/common/sfc_efx/base/efx_impl.h:321:
+	efx_rc_t	(*evo_get_features)(efx_nic_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t *' should also have an identifier name
#113: FILE: drivers/common/sfc_efx/base/efx_impl.h:321:
+	efx_rc_t	(*evo_get_features)(efx_nic_t *,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#161: FILE: drivers/common/sfc_efx/base/efx_virtio.c:285:
+	if ((rc = evop->evo_get_features(enp, type, featuresp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#164: FILE: drivers/common/sfc_efx/base/efx_virtio.c:288:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#175: FILE: drivers/common/sfc_efx/base/efx_virtio.c:299:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#247: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:325:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#254: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:332:
+	return (rc);

total: 5 errors, 3 warnings, 158 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-16  8:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210316085832.942481-5-andrew.rybchenko@oktetlabs.ru>
2021-03-16  8:59 ` [dpdk-test-report] |WARNING| pw89199 [PATCH v4 4/8] common/sfc_efx/base: add support to get virtio features checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).