From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [dpdk-test-report] |WARNING| pw89200 [PATCH v4 5/8] common/sfc_efx/base: add support to verify virtio features
Date: Tue, 16 Mar 2021 09:59:55 +0100 (CET) [thread overview]
Message-ID: <20210316085955.8A5602BE3@dpdk.org> (raw)
In-Reply-To: <20210316085832.942481-6-andrew.rybchenko@oktetlabs.ru>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89200
_coding style issues_
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#99: FILE: drivers/common/sfc_efx/base/efx_impl.h:323:
+ efx_rc_t (*evo_verify_features)(efx_nic_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_device_type_t' should also have an identifier name
#99: FILE: drivers/common/sfc_efx/base/efx_impl.h:323:
+ efx_rc_t (*evo_verify_features)(efx_nic_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#99: FILE: drivers/common/sfc_efx/base/efx_impl.h:323:
+ efx_rc_t (*evo_verify_features)(efx_nic_t *,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#142: FILE: drivers/common/sfc_efx/base/efx_virtio.c:325:
+ if ((rc = evop->evo_verify_features(enp, type, features)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#145: FILE: drivers/common/sfc_efx/base/efx_virtio.c:328:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#154: FILE: drivers/common/sfc_efx/base/efx_virtio.c:337:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#225: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:376:
+ return (rc);
total: 4 errors, 3 warnings, 130 lines checked
parent reply other threads:[~2021-03-16 8:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210316085832.942481-6-andrew.rybchenko@oktetlabs.ru>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316085955.8A5602BE3@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).