From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: <pbhagavatula@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw89598 [PATCH v2 1/4] event/octeontx2: simplify timer bucket estimation
Date: Sun, 21 Mar 2021 09:50:10 +0100 (CET) [thread overview]
Message-ID: <20210321085010.556CD36C@dpdk.org> (raw)
In-Reply-To: <20210321084915.2649-1-pbhagavatula@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89598
_coding style issues_
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#103: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:40:
+ [_f3][_f2][_f1] = otx2_tim_arm_burst_##_name,
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#104: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:41:
+ TIM_ARM_FASTPATH_MODES
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#114: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:47:
+ [_f2][_f1] = otx2_tim_arm_tmo_tick_burst_##_name,
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#115: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:48:
+ TIM_ARM_TMO_FASTPATH_MODES
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#122: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:53:
+ arm_burst[tim_ring->enable_stats][tim_ring->ena_dfb][prod_flag];
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#122: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:53:
+ arm_burst[tim_ring->enable_stats][tim_ring->ena_dfb][prod_flag];
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#126: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:55:
+ arm_tmo_burst[tim_ring->enable_stats][tim_ring->ena_dfb];
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#126: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:55:
+ arm_tmo_burst[tim_ring->enable_stats][tim_ring->ena_dfb];
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#201: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:407:
+ tim_ring->fast_bkt = rte_reciprocal_value_u64(tim_ring->nb_bkts);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#201: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:407:
+ tim_ring->fast_bkt = rte_reciprocal_value_u64(tim_ring->nb_bkts);
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#280: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:179:
+#define TIM_ARM_FASTPATH_MODES \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#280: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:179:
+#define TIM_ARM_FASTPATH_MODES \
+ FP(sp, 0, 0, 0, OTX2_TIM_ENA_DFB | OTX2_TIM_SP) \
+ FP(mp, 0, 0, 1, OTX2_TIM_ENA_DFB | OTX2_TIM_MP) \
+ FP(fb_sp, 0, 1, 0, OTX2_TIM_ENA_FB | OTX2_TIM_SP) \
+ FP(fb_mp, 0, 1, 1, OTX2_TIM_ENA_FB | OTX2_TIM_MP) \
+ FP(stats_mod_sp, 1, 0, 0, \
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB | OTX2_TIM_SP) \
+ FP(stats_mod_mp, 1, 0, 1, \
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB | OTX2_TIM_MP) \
+ FP(stats_mod_fb_sp, 1, 1, 0, \
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB | OTX2_TIM_SP) \
+ FP(stats_mod_fb_mp, 1, 1, 1, \
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB | OTX2_TIM_MP)
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#281: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:180:
+ FP(sp, 0, 0, 0, OTX2_TIM_ENA_DFB | OTX2_TIM_SP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#281: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:180:
+ FP(sp, 0, 0, 0, OTX2_TIM_ENA_DFB | OTX2_TIM_SP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#282: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:181:
+ FP(mp, 0, 0, 1, OTX2_TIM_ENA_DFB | OTX2_TIM_MP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#282: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:181:
+ FP(mp, 0, 0, 1, OTX2_TIM_ENA_DFB | OTX2_TIM_MP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#283: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:182:
+ FP(fb_sp, 0, 1, 0, OTX2_TIM_ENA_FB | OTX2_TIM_SP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#283: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:182:
+ FP(fb_sp, 0, 1, 0, OTX2_TIM_ENA_FB | OTX2_TIM_SP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#284: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:183:
+ FP(fb_mp, 0, 1, 1, OTX2_TIM_ENA_FB | OTX2_TIM_MP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#284: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:183:
+ FP(fb_mp, 0, 1, 1, OTX2_TIM_ENA_FB | OTX2_TIM_MP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#286: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:185:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB | OTX2_TIM_SP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#286: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:185:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB | OTX2_TIM_SP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#286: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:185:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB | OTX2_TIM_SP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#288: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:187:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB | OTX2_TIM_MP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#288: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:187:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB | OTX2_TIM_MP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#288: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:187:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB | OTX2_TIM_MP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#290: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:189:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB | OTX2_TIM_SP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#290: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:189:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB | OTX2_TIM_SP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#290: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:189:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB | OTX2_TIM_SP) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#292: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:191:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB | OTX2_TIM_MP)
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#292: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:191:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB | OTX2_TIM_MP)
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#292: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:191:
+ OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB | OTX2_TIM_MP)
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#294: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:193:
+#define TIM_ARM_TMO_FASTPATH_MODES \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#294: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:193:
+#define TIM_ARM_TMO_FASTPATH_MODES \
+ FP(dfb, 0, 0, OTX2_TIM_ENA_DFB) \
+ FP(fb, 0, 1, OTX2_TIM_ENA_FB) \
+ FP(stats_dfb, 1, 0, OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB) \
+ FP(stats_fb, 1, 1, OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB)
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#295: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:194:
+ FP(dfb, 0, 0, OTX2_TIM_ENA_DFB) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#296: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:195:
+ FP(fb, 0, 1, OTX2_TIM_ENA_FB) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#297: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:196:
+ FP(stats_dfb, 1, 0, OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#297: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:196:
+ FP(stats_dfb, 1, 0, OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_DFB) \
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#298: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:197:
+ FP(stats_fb, 1, 1, OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB)
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#298: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:197:
+ FP(stats_fb, 1, 1, OTX2_TIM_ENA_STATS | OTX2_TIM_ENA_FB)
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#300: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:199:
+#define FP(_name, _f3, _f2, _f1, flags) \
+ uint16_t otx2_tim_arm_burst_##_name( \
+ const struct rte_event_timer_adapter *adptr, \
+ struct rte_event_timer **tim, const uint16_t nb_timers);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#301: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:200:
+ uint16_t otx2_tim_arm_burst_##_name( \
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#303: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:202:
+ struct rte_event_timer **tim, const uint16_t nb_timers);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#313: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:206:
+#define FP(_name, _f2, _f1, flags) \
+ uint16_t otx2_tim_arm_tmo_tick_burst_##_name( \
+ const struct rte_event_timer_adapter *adptr, \
+ struct rte_event_timer **tim, const uint64_t timeout_tick, \
+ const uint16_t nb_timers);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#314: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:207:
+ uint16_t otx2_tim_arm_tmo_tick_burst_##_name( \
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#316: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:209:
+ struct rte_event_timer **tim, const uint64_t timeout_tick, \
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#352: FILE: drivers/event/octeontx2/otx2_tim_worker.h:119:
+tim_bkt_fast_mod(uint64_t n, uint64_t d, struct rte_reciprocal_u64 R)
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#359: FILE: drivers/event/octeontx2/otx2_tim_worker.h:125:
+tim_get_target_bucket(struct otx2_tim_ring *const tim_ring,
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#359: FILE: drivers/event/octeontx2/otx2_tim_worker.h:125:
+tim_get_target_bucket(struct otx2_tim_ring *const tim_ring,
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#359: FILE: drivers/event/octeontx2/otx2_tim_worker.h:125:
+tim_get_target_bucket(struct otx2_tim_ring *const tim_ring,
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#362: FILE: drivers/event/octeontx2/otx2_tim_worker.h:127:
+ struct otx2_tim_bkt **mirr_bkt)
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#381: FILE: drivers/event/octeontx2/otx2_tim_worker.h:131:
+ rte_reciprocal_divide_u64(bkt_cyc, &tim_ring->fast_div) +
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#386: FILE: drivers/event/octeontx2/otx2_tim_worker.h:136:
+ tim_bkt_fast_mod(bucket, tim_ring->nb_bkts, tim_ring->fast_bkt);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#386: FILE: drivers/event/octeontx2/otx2_tim_worker.h:136:
+ tim_bkt_fast_mod(bucket, tim_ring->nb_bkts, tim_ring->fast_bkt);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#386: FILE: drivers/event/octeontx2/otx2_tim_worker.h:136:
+ tim_bkt_fast_mod(bucket, tim_ring->nb_bkts, tim_ring->fast_bkt);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#387: FILE: drivers/event/octeontx2/otx2_tim_worker.h:137:
+ mirr_bucket = tim_bkt_fast_mod(bucket + (tim_ring->nb_bkts >> 1),
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#387: FILE: drivers/event/octeontx2/otx2_tim_worker.h:137:
+ mirr_bucket = tim_bkt_fast_mod(bucket + (tim_ring->nb_bkts >> 1),
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#388: FILE: drivers/event/octeontx2/otx2_tim_worker.h:138:
+ tim_ring->nb_bkts, tim_ring->fast_bkt);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#388: FILE: drivers/event/octeontx2/otx2_tim_worker.h:138:
+ tim_ring->nb_bkts, tim_ring->fast_bkt);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#397: FILE: drivers/event/octeontx2/otx2_tim_worker.h:239:
+ tim_get_target_bucket(tim_ring, rel_bkt, &bkt, &mirr_bkt);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#397: FILE: drivers/event/octeontx2/otx2_tim_worker.h:239:
+ tim_get_target_bucket(tim_ring, rel_bkt, &bkt, &mirr_bkt);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#406: FILE: drivers/event/octeontx2/otx2_tim_worker.h:325:
+ tim_get_target_bucket(tim_ring, rel_bkt, &bkt, &mirr_bkt);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#406: FILE: drivers/event/octeontx2/otx2_tim_worker.h:325:
+ tim_get_target_bucket(tim_ring, rel_bkt, &bkt, &mirr_bkt);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#415: FILE: drivers/event/octeontx2/otx2_tim_worker.h:457:
+ tim_get_target_bucket(tim_ring, rel_bkt, &bkt, &mirr_bkt);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#415: FILE: drivers/event/octeontx2/otx2_tim_worker.h:457:
+ tim_get_target_bucket(tim_ring, rel_bkt, &bkt, &mirr_bkt);
total: 2 errors, 63 warnings, 303 lines checked
parent reply other threads:[~2021-03-21 8:50 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210321084915.2649-1-pbhagavatula@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210321085010.556CD36C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=pbhagavatula@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).