From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D3D36A09E4
	for <public@inbox.dpdk.org>; Thu, 22 Apr 2021 08:16:40 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CFC88413FA;
	Thu, 22 Apr 2021 08:16:40 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 143A2413E6
 for <test-report@dpdk.org>; Thu, 22 Apr 2021 08:16:39 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id ECC7D121158; Thu, 22 Apr 2021 08:16:38 +0200 (CEST)
In-Reply-To: <20210422061540.23304-2-richael.zhuang@arm.com>
References: <20210422061540.23304-2-richael.zhuang@arm.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Richael Zhuang <richael.zhuang@arm.com>
Message-Id: <20210422061638.ECC7D121158@dpdk.org>
Date: Thu, 22 Apr 2021 08:16:38 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw91998 [PATCH v1 1/1] power: add
 support for cppc cpufreq
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/91998

_coding style issues_


WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#125: FILE: lib/power/power_cppc_cpufreq.c:12:
+#define POWER_DEBUG_TRACE(fmt, args...) do { \
+		RTE_LOG(ERR, POWER, "%s: " fmt, __func__, ## args); \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#132: FILE: lib/power/power_cppc_cpufreq.c:19:
+#define FOPEN_OR_ERR_RET(f, retval) do { \
+		if ((f) == NULL) { \
+			RTE_LOG(ERR, POWER, "File not opened
"); \
+			return retval; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#139: FILE: lib/power/power_cppc_cpufreq.c:26:
+#define FOPS_OR_NULL_GOTO(ret, label) do { \
+		if ((ret) == NULL) { \
+			RTE_LOG(ERR, POWER, "fgets returns nothing
"); \
+			goto label; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#146: FILE: lib/power/power_cppc_cpufreq.c:33:
+#define FOPS_OR_ERR_GOTO(ret, label) do { \
+		if ((ret) < 0) { \
+			RTE_LOG(ERR, POWER, "File operations failed
"); \
+			goto label; \
+		} \
+} while (0)

total: 0 errors, 4 warnings, 1131 lines checked