From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gregory Etelson <getelson@nvidia.com>
Subject: [dpdk-test-report] |WARNING| pw92343 [PATCH 3/4] net/mlx5: support integrity flow item
Date: Wed, 28 Apr 2021 20:01:02 +0200 (CEST) [thread overview]
Message-ID: <20210428180102.3F5C8121159@dpdk.org> (raw)
In-Reply-To: <20210428175906.21387-4-getelson@nvidia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/92343
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_s' - possible side-effects?
#211: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+ (_prt) = ((const struct _s *)(_itm)->mask)->_m; \
+ (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \
+ (_prt) = rte_be_to_cpu_16((_prt)); \
+} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_s' may be better as '(_s)' to avoid precedence issues
#211: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+ (_prt) = ((const struct _s *)(_itm)->mask)->_m; \
+ (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \
+ (_prt) = rte_be_to_cpu_16((_prt)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_m' - possible side-effects?
#211: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+ (_prt) = ((const struct _s *)(_itm)->mask)->_m; \
+ (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \
+ (_prt) = rte_be_to_cpu_16((_prt)); \
+} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_m' may be better as '(_m)' to avoid precedence issues
#211: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+ (_prt) = ((const struct _s *)(_itm)->mask)->_m; \
+ (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \
+ (_prt) = rte_be_to_cpu_16((_prt)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_itm' - possible side-effects?
#211: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+ (_prt) = ((const struct _s *)(_itm)->mask)->_m; \
+ (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \
+ (_prt) = rte_be_to_cpu_16((_prt)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_prt' - possible side-effects?
#211: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+ (_prt) = ((const struct _s *)(_itm)->mask)->_m; \
+ (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \
+ (_prt) = rte_be_to_cpu_16((_prt)); \
+} while (0)
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#227: FILE: drivers/net/mlx5/mlx5_flow.h:1305:
+ for (; item->type != RTE_FLOW_ITEM_TYPE_END; item++);
total: 1 errors, 0 warnings, 6 checks, 369 lines checked
parent reply other threads:[~2021-04-28 18:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210428175906.21387-4-getelson@nvidia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428180102.3F5C8121159@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=getelson@nvidia.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).