From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E3B89A0A0E
	for <public@inbox.dpdk.org>; Thu, 29 Apr 2021 08:18:04 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DFB564067E;
	Thu, 29 Apr 2021 08:18:04 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 688304003E
 for <test-report@dpdk.org>; Thu, 29 Apr 2021 08:18:03 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 64462121159; Thu, 29 Apr 2021 08:18:03 +0200 (CEST)
In-Reply-To: <20210429061634.3481-4-getelson@nvidia.com>
References: <20210429061634.3481-4-getelson@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Gregory Etelson <getelson@nvidia.com>
Message-Id: <20210429061803.64462121159@dpdk.org>
Date: Thu, 29 Apr 2021 08:18:03 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw92375 [PATCH v2 3/4] net/mlx5:
 support integrity flow item
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/92375

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_s' - possible side-effects?
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_s' may be better as '(_s)' to avoid precedence issues
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_m' - possible side-effects?
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_m' may be better as '(_m)' to avoid precedence issues
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_itm' - possible side-effects?
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_prt' - possible side-effects?
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#228: FILE: drivers/net/mlx5/mlx5_flow.h:1305:
+	for (; item->type != RTE_FLOW_ITEM_TYPE_END; item++);

total: 1 errors, 0 warnings, 6 checks, 369 lines checked