From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3B77A0547 for ; Thu, 29 Apr 2021 20:38:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B03AC410DF; Thu, 29 Apr 2021 20:38:29 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 36F0B410DD for ; Thu, 29 Apr 2021 20:38:28 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 31C82121159; Thu, 29 Apr 2021 20:38:28 +0200 (CEST) In-Reply-To: <20210429183659.14765-4-getelson@nvidia.com> References: <20210429183659.14765-4-getelson@nvidia.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Gregory Etelson Message-Id: <20210429183828.31C82121159@dpdk.org> Date: Thu, 29 Apr 2021 20:38:28 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw92451 [PATCH v3 3/4] net/mlx5: support integrity flow item X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/92451 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse '_s' - possible side-effects? #169: FILE: drivers/net/mlx5/mlx5_flow.h:1018: +#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \ + (_prt) = ((const struct _s *)(_itm)->mask)->_m; \ + (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \ + (_prt) = rte_be_to_cpu_16((_prt)); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_s' may be better as '(_s)' to avoid precedence issues #169: FILE: drivers/net/mlx5/mlx5_flow.h:1018: +#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \ + (_prt) = ((const struct _s *)(_itm)->mask)->_m; \ + (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \ + (_prt) = rte_be_to_cpu_16((_prt)); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_m' - possible side-effects? #169: FILE: drivers/net/mlx5/mlx5_flow.h:1018: +#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \ + (_prt) = ((const struct _s *)(_itm)->mask)->_m; \ + (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \ + (_prt) = rte_be_to_cpu_16((_prt)); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_m' may be better as '(_m)' to avoid precedence issues #169: FILE: drivers/net/mlx5/mlx5_flow.h:1018: +#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \ + (_prt) = ((const struct _s *)(_itm)->mask)->_m; \ + (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \ + (_prt) = rte_be_to_cpu_16((_prt)); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_itm' - possible side-effects? #169: FILE: drivers/net/mlx5/mlx5_flow.h:1018: +#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \ + (_prt) = ((const struct _s *)(_itm)->mask)->_m; \ + (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \ + (_prt) = rte_be_to_cpu_16((_prt)); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_prt' - possible side-effects? #169: FILE: drivers/net/mlx5/mlx5_flow.h:1018: +#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \ + (_prt) = ((const struct _s *)(_itm)->mask)->_m; \ + (_prt) &= ((const struct _s *)(_itm)->spec)->_m; \ + (_prt) = rte_be_to_cpu_16((_prt)); \ +} while (0) ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #185: FILE: drivers/net/mlx5/mlx5_flow.h:1299: + for (; item->type != RTE_FLOW_ITEM_TYPE_END; item++); total: 1 errors, 0 warnings, 6 checks, 400 lines checked