automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [dpdk-test-report] |WARNING| pw93519 [PATCH 19/20] net/sfc: support flow action COUNT in transfer rules
Date: Thu, 27 May 2021 17:29:00 +0200 (CEST)	[thread overview]
Message-ID: <20210527152900.421ED122E1E@dpdk.org> (raw)
In-Reply-To: <20210527152510.1551026-20-andrew.rybchenko@oktetlabs.ru>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93519

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EALREADY)
#260: FILE: drivers/net/sfc/sfc_mae.c:566:
+		return EALREADY;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#317: FILE: drivers/net/sfc/sfc_mae.c:628:
+			return ENOMEM;

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#700: FILE: drivers/net/sfc/sfc_mae_counter.c:109:
+	sfc_info(sa, "enabled MAE counter #%u with reset pkts=%" PRIu64

WARNING:TYPO_SPELLING: 'sevice' may be misspelled - perhaps 'service'?
#1027: FILE: drivers/net/sfc/sfc_mae_counter.c:436:
+	char counter_service_name[sizeof(service.name)] = "counter_sevice";

total: 0 errors, 3 warnings, 1 checks, 1201 lines checked

           reply	other threads:[~2021-05-27 15:29 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20210527152510.1551026-20-andrew.rybchenko@oktetlabs.ru>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210527152900.421ED122E1E@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).