From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw93560 [PATCH 11/58] net/bnxt: add hashing changes for Thor
Date: Sun, 30 May 2021 11:03:01 +0200 (CEST) [thread overview]
Message-ID: <20210530090301.5CD07122E1E@dpdk.org> (raw)
In-Reply-To: <20210530085929.29695-12-venkatkumar.duvvuru@broadcom.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93560
_coding style issues_
WARNING:TYPO_SPELLING: 'bae' may be misspelled - perhaps 'base'?
#236: FILE: drivers/net/bnxt/hcapi/cfa/hcapi_cfa_common.c:61:
+0x95bf4a82, 0xe2b87a14, 0x7bb12bae, 0x0cb61b38,
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crc' - possible side-effects?
#275: FILE: drivers/net/bnxt/hcapi/cfa/hcapi_cfa_defs.h:63:
+#define ucrc32(ch, crc) (crc32tbl[((crc) ^ (ch)) & 0xff] ^ ((crc) >> 8))
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#308: FILE: drivers/net/bnxt/hcapi/cfa/hcapi_cfa_p4.c:19:
+extern const uint32_t crc32tbl[];
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#450: FILE: drivers/net/bnxt/hcapi/cfa/hcapi_cfa_p58.c:19:
+extern const uint32_t crc32tbl[];
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#617: FILE: drivers/net/bnxt/tf_core/tf_device_p4.c:21:
+uint64_t hcapi_cfa_key_hash_p4(uint64_t *key_data,
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#637: FILE: drivers/net/bnxt/tf_core/tf_device_p58.c:21:
+uint64_t hcapi_cfa_key_hash_p58(uint64_t *key_data,
total: 0 errors, 5 warnings, 1 checks, 667 lines checked
parent reply other threads:[~2021-05-30 9:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210530085929.29695-12-venkatkumar.duvvuru@broadcom.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210530090301.5CD07122E1E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=venkatkumar.duvvuru@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).