From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D682AA0C48
	for <public@inbox.dpdk.org>; Tue,  6 Jul 2021 22:31:11 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D040041330;
	Tue,  6 Jul 2021 22:31:11 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id BACA54120E
 for <test-report@dpdk.org>; Tue,  6 Jul 2021 22:31:10 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id B63A41206FD; Tue,  6 Jul 2021 22:31:10 +0200 (CEST)
In-Reply-To: <20210706202841.661302-10-bruce.richardson@intel.com>
References: <20210706202841.661302-10-bruce.richardson@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Message-Id: <20210706203110.B63A41206FD@dpdk.org>
Date: Tue,  6 Jul 2021 22:31:10 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw95430 [RFC UPDATE PATCH 9/9]
 app/test: add basic dmadev unit test
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/95430

_coding style issues_


ERROR:INITIALISED_STATIC: do not initialise statics to 0
#106: FILE: app/test/test_dmadev.c:14:
+static uint16_t id_count = 0;

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#177: FILE: app/test/test_dmadev.c:85:
+		if ((j = rte_dmadev_completed(dev_id, 0, RTE_DIM(srcs), NULL,

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#257: FILE: app/test/test_dmadev.c:165:
+			PRINT_ERR("Error:incorrect job id received, %u [expected %u]
", id, id_count);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#300: FILE: app/test/test_dmadev.c:208:
+		if ((i = rte_dmadev_completed(dev_id, 0, max_ops * 2, &id, NULL)) != max_ops) {

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#305: FILE: app/test/test_dmadev.c:213:
+			PRINT_ERR("Error, incorrect job id returned: got %u not %u
", id, id_count - 1);

WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#320: FILE: app/test/test_dmadev.c:228:
+			|| do_multi_copies(dev_id, 1, 0) /* enqueue 2 batches and then complete both */

WARNING:LONG_LINE_COMMENT: line length of 108 exceeds 100 columns
#321: FILE: app/test/test_dmadev.c:229:
+			|| do_multi_copies(dev_id, 0, 1); /* enqueue 1 batch, then complete in two halves */

total: 3 errors, 4 warnings, 334 lines checked