* [dpdk-test-report] |WARNING| pw95430 [RFC UPDATE PATCH 9/9] app/test: add basic dmadev unit test
[not found] <20210706202841.661302-10-bruce.richardson@intel.com>
@ 2021-07-06 20:31 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-07-06 20:31 UTC (permalink / raw)
To: test-report; +Cc: Bruce Richardson
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/95430
_coding style issues_
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#106: FILE: app/test/test_dmadev.c:14:
+static uint16_t id_count = 0;
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#177: FILE: app/test/test_dmadev.c:85:
+ if ((j = rte_dmadev_completed(dev_id, 0, RTE_DIM(srcs), NULL,
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#257: FILE: app/test/test_dmadev.c:165:
+ PRINT_ERR("Error:incorrect job id received, %u [expected %u]
", id, id_count);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#300: FILE: app/test/test_dmadev.c:208:
+ if ((i = rte_dmadev_completed(dev_id, 0, max_ops * 2, &id, NULL)) != max_ops) {
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#305: FILE: app/test/test_dmadev.c:213:
+ PRINT_ERR("Error, incorrect job id returned: got %u not %u
", id, id_count - 1);
WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#320: FILE: app/test/test_dmadev.c:228:
+ || do_multi_copies(dev_id, 1, 0) /* enqueue 2 batches and then complete both */
WARNING:LONG_LINE_COMMENT: line length of 108 exceeds 100 columns
#321: FILE: app/test/test_dmadev.c:229:
+ || do_multi_copies(dev_id, 0, 1); /* enqueue 1 batch, then complete in two halves */
total: 3 errors, 4 warnings, 334 lines checked
^ permalink raw reply [flat|nested] only message in thread