From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [dpdk-test-report] |WARNING| pw95629 [PATCH 1/4] ethdev: fix max Rx packet length
Date: Fri, 9 Jul 2021 19:31:20 +0200 (CEST) [thread overview]
Message-ID: <20210709173120.39EAA120736@dpdk.org> (raw)
In-Reply-To: <20210709172923.3369846-1-ferruh.yigit@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/95629
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_rx_pktlen > avp->guest_mbuf_size'
#882: FILE: drivers/net/avp/avp_ethdev.c:1067:
+ if ((max_rx_pktlen > avp->guest_mbuf_size) ||
+ (max_rx_pktlen > avp->host_mbuf_size)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_rx_pktlen > avp->host_mbuf_size'
#882: FILE: drivers/net/avp/avp_ethdev.c:1067:
+ if ((max_rx_pktlen > avp->guest_mbuf_size) ||
+ (max_rx_pktlen > avp->host_mbuf_size)) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1058: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1731:
+ slave_eth_dev->data->dev_conf.rxmode.mtu =
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#1072: FILE: drivers/net/cnxk/cnxk_ethdev.c:56:
+ if (eth_dev->data->mtu + (uint32_t)CNXK_NIX_L2_OVERHEAD > buffsz) {
ERROR:SPACING: space required before the open brace '{'
#1482: FILE: drivers/net/e1000/igb_rxtx.c:2425:
+ if ((max_len + 2 * VLAN_TAG_SIZE) > buf_size){
ERROR:SPACING: space required before the open brace '{'
#1511: FILE: drivers/net/e1000/igb_rxtx.c:2714:
+ if ((max_len + 2 * VLAN_TAG_SIZE) > buf_size){
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#3060: FILE: drivers/net/octeontx2/otx2_ethdev.c:915:
+ if (eth_dev->data->mtu + (uint32_t)NIX_L2_OVERHEAD > buffsz) {
total: 2 errors, 3 warnings, 3272 lines checked
parent reply other threads:[~2021-07-09 17:31 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210709172923.3369846-1-ferruh.yigit@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210709173120.39EAA120736@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).