From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Chengwen Feng <fengchengwen@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw95774 [PATCH v3] dmadev: introduce DMA device library
Date: Tue, 13 Jul 2021 14:33:15 +0200 (CEST) [thread overview]
Message-ID: <20210713123315.7513D120F1F@dpdk.org> (raw)
In-Reply-To: <1626179263-14645-1-git-send-email-fengchengwen@huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/95774
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#188: FILE: lib/dmadev/rte_dmadev.c:40:
+#define RTE_DMADEV_VALID_DEV_ID_OR_ERR_RET(dev_id, retval) do { \
+ if (!rte_dmadev_is_valid_dev(dev_id)) { \
+ RTE_DMADEV_LOG(ERR, "Invalid dev_id=%u
", dev_id); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#195: FILE: lib/dmadev/rte_dmadev.c:47:
+#define RTE_DMADEV_VALID_DEV_ID_OR_RET(dev_id) do { \
+ if (!rte_dmadev_is_valid_dev(dev_id)) { \
+ RTE_DMADEV_LOG(ERR, "Invalid dev_id=%u
", dev_id); \
+ return; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#203: FILE: lib/dmadev/rte_dmadev.c:55:
+#define RTE_DMADEV_PTR_OR_ERR_RET(ptr, retval) do { \
+ if ((ptr) == NULL) \
+ return retval; \
+} while (0)
total: 0 errors, 3 warnings, 1832 lines checked
Warning in lib/dmadev/rte_dmadev.c:
Using RTE_LOG_REGISTER, prefer RTE_LOG_REGISTER_(DEFAULT|SUFFIX)
next parent reply other threads:[~2021-07-13 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1626179263-14645-1-git-send-email-fengchengwen@huawei.com>
2021-07-13 12:33 ` checkpatch [this message]
2021-07-13 12:59 ` [dpdk-test-report] |SUCCESS| pw95774 [dpdk-dev] " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713123315.7513D120F1F@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).