From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E9057A0C51
	for <public@inbox.dpdk.org>; Tue, 13 Jul 2021 14:33:16 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C9E41410E8;
	Tue, 13 Jul 2021 14:33:16 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 8F0FB410E6
 for <test-report@dpdk.org>; Tue, 13 Jul 2021 14:33:15 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 7513D120F1F; Tue, 13 Jul 2021 14:33:15 +0200 (CEST)
In-Reply-To: <1626179263-14645-1-git-send-email-fengchengwen@huawei.com>
References: <1626179263-14645-1-git-send-email-fengchengwen@huawei.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Chengwen Feng <fengchengwen@huawei.com>
Message-Id: <20210713123315.7513D120F1F@dpdk.org>
Date: Tue, 13 Jul 2021 14:33:15 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw95774 [PATCH v3] dmadev: introduce
 DMA device library
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/95774

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#188: FILE: lib/dmadev/rte_dmadev.c:40:
+#define RTE_DMADEV_VALID_DEV_ID_OR_ERR_RET(dev_id, retval) do { \
+	if (!rte_dmadev_is_valid_dev(dev_id)) { \
+		RTE_DMADEV_LOG(ERR, "Invalid dev_id=%u
", dev_id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#195: FILE: lib/dmadev/rte_dmadev.c:47:
+#define RTE_DMADEV_VALID_DEV_ID_OR_RET(dev_id) do { \
+	if (!rte_dmadev_is_valid_dev(dev_id)) { \
+		RTE_DMADEV_LOG(ERR, "Invalid dev_id=%u
", dev_id); \
+		return; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#203: FILE: lib/dmadev/rte_dmadev.c:55:
+#define RTE_DMADEV_PTR_OR_ERR_RET(ptr, retval) do { \
+	if ((ptr) == NULL) \
+		return retval; \
+} while (0)

total: 0 errors, 3 warnings, 1832 lines checked
Warning in lib/dmadev/rte_dmadev.c:
Using RTE_LOG_REGISTER, prefer RTE_LOG_REGISTER_(DEFAULT|SUFFIX)