[dpdk-test-report] |WARNING| pw97168 [RFC 2/7] eth: make drivers to use new API for Rx

automatic DPDK test reports
 help / color / mirror / Atom feed

* [dpdk-test-report] |WARNING| pw97168 [RFC 2/7] eth: make drivers to use new API for Rx
       [not found] <20210820162834.12544-3-konstantin.ananyev@intel.com>
@ 2021-08-20 16:30 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-08-20 16:30 UTC (permalink / raw)
  To: test-report; +Cc: Konstantin Ananyev

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97168

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#245: FILE: drivers/net/i40e/i40e_rxtx.c:3323:
+					_RTE_ETH_FUNC(

ERROR:TRAILING_WHITESPACE: trailing whitespace
#247: FILE: drivers/net/i40e/i40e_rxtx.c:3325:
+^I^I^I^I^I$

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#259: FILE: drivers/net/i40e/i40e_rxtx.c:3334:
+					_RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#261: FILE: drivers/net/i40e/i40e_rxtx.c:3336:
+					 _RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#273: FILE: drivers/net/i40e/i40e_rxtx.c:3346:
+					_RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#334: FILE: drivers/net/i40e/i40e_rxtx.c:3397:
+			(rx_burst == _RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#340: FILE: drivers/net/i40e/i40e_rxtx.c:3401:
+			 rx_burst == _RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#346: FILE: drivers/net/i40e/i40e_rxtx.c:3405:
+			 rx_burst == _RTE_ETH_FUNC(

ERROR:CODE_INDENT: code indent should use tabs where possible
#347: FILE: drivers/net/i40e/i40e_rxtx.c:3406:
+^I^I^I^I ^Ii40e_recv_scattered_pkts_vec_avx2) ||$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#347: FILE: drivers/net/i40e/i40e_rxtx.c:3406:
+^I^I^I^I ^Ii40e_recv_scattered_pkts_vec_avx2) ||$

ERROR:CODE_INDENT: code indent should use tabs where possible
#761: FILE: drivers/net/ice/ice_rxtx.c:2011:
+^I    ^I_RTE_ETH_FUNC(ice_recv_scattered_pkts_vec_avx512_offload) ||$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#761: FILE: drivers/net/ice/ice_rxtx.c:2011:
+^I    ^I_RTE_ETH_FUNC(ice_recv_scattered_pkts_vec_avx512_offload) ||$

ERROR:CODE_INDENT: code indent should use tabs where possible
#771: FILE: drivers/net/ice/ice_rxtx.c:2017:
+^I    ^I_RTE_ETH_FUNC(ice_recv_scattered_pkts_vec_avx2_offload))$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#771: FILE: drivers/net/ice/ice_rxtx.c:2017:
+^I    ^I_RTE_ETH_FUNC(ice_recv_scattered_pkts_vec_avx2_offload))$

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#800: FILE: drivers/net/ice/ice_rxtx.c:3122:
+						_RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#809: FILE: drivers/net/ice/ice_rxtx.c:3129:
+						_RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#821: FILE: drivers/net/ice/ice_rxtx.c:3139:
+						_RTE_ETH_FUNC(

WARNING:LONG_LINE: line length of 142 exceeds 100 columns
#829: FILE: drivers/net/ice/ice_rxtx.c:3145:
+					rte_eth_set_rx_burst(dev->data->port_id,						_RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#829: FILE: drivers/net/ice/ice_rxtx.c:3145:
+					rte_eth_set_rx_burst(dev->data->port_id,						_RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#838: FILE: drivers/net/ice/ice_rxtx.c:3153:
+					_RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#850: FILE: drivers/net/ice/ice_rxtx.c:3164:
+						_RTE_ETH_FUNC(

WARNING:LONG_LINE: line length of 142 exceeds 100 columns
#858: FILE: drivers/net/ice/ice_rxtx.c:3170:
+					rte_eth_set_rx_burst(dev->data->port_id,						_RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#858: FILE: drivers/net/ice/ice_rxtx.c:3170:
+					rte_eth_set_rx_burst(dev->data->port_id,						_RTE_ETH_FUNC(

WARNING:LONG_LINE: line length of 142 exceeds 100 columns
#869: FILE: drivers/net/ice/ice_rxtx.c:3179:
+					rte_eth_set_rx_burst(dev->data->port_id,						_RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#869: FILE: drivers/net/ice/ice_rxtx.c:3179:
+					rte_eth_set_rx_burst(dev->data->port_id,						_RTE_ETH_FUNC(

WARNING:LONG_LINE: line length of 142 exceeds 100 columns
#877: FILE: drivers/net/ice/ice_rxtx.c:3185:
+					rte_eth_set_rx_burst(dev->data->port_id,						_RTE_ETH_FUNC(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#877: FILE: drivers/net/ice/ice_rxtx.c:3185:
+					rte_eth_set_rx_burst(dev->data->port_id,						_RTE_ETH_FUNC(

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1353: FILE: lib/ethdev/ethdev_driver.h:1619:
+#define _RTE_ETH_RX_DEF(fn) \
+_RTE_ETH_RX_PROTO(fn) \
+{ \
+	uint16_t nb_rx; \
+	void *rxq = _rte_eth_rx_prolog(port_id, queue_id); \
+	if (rxq == NULL) \
+		return 0; \
+	nb_rx = fn(rxq, rx_pkts, nb_pkts); \
+	return _rte_eth_rx_epilog(port_id, queue_id, rx_pkts, nb_rx, nb_pkts); \
+}

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1353: FILE: lib/ethdev/ethdev_driver.h:1619:
+#define _RTE_ETH_RX_DEF(fn) \
+_RTE_ETH_RX_PROTO(fn) \
+{ \
+	uint16_t nb_rx; \
+	void *rxq = _rte_eth_rx_prolog(port_id, queue_id); \
+	if (rxq == NULL) \
+		return 0; \
+	nb_rx = fn(rxq, rx_pkts, nb_pkts); \
+	return _rte_eth_rx_epilog(port_id, queue_id, rx_pkts, nb_rx, nb_pkts); \
+}

total: 5 errors, 8 warnings, 1264 lines checked
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-20 16:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210820162834.12544-3-konstantin.ananyev@intel.com>
2021-08-20 16:30 ` [dpdk-test-report] |WARNING| pw97168 [RFC 2/7] eth: make drivers to use new API for Rx checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).