automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: [dpdk-test-report] |WARNING| pw97169 [RFC 3/7] eth: make drivers to use new API for Tx
Date: Fri, 20 Aug 2021 18:30:28 +0200 (CEST)	[thread overview]
Message-ID: <20210820163028.BCAB81226B3@dpdk.org> (raw)
In-Reply-To: <20210820162834.12544-4-konstantin.ananyev@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97169

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#242: FILE: drivers/net/i40e/i40e_rxtx.c:3574:
+					_RTE_ETH_FUNC(

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#841: FILE: lib/ethdev/ethdev_driver.h:1715:
+#define _RTE_ETH_TX_DEF(fn) \
+_RTE_ETH_TX_PROTO(fn) \
+{ \
+	void *txq = _rte_eth_tx_prolog(port_id, queue_id, tx_pkts, &nb_pkts); \
+	if (txq == NULL) \
+		return 0; \
+	return fn(txq, tx_pkts, nb_pkts); \
+}

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#841: FILE: lib/ethdev/ethdev_driver.h:1715:
+#define _RTE_ETH_TX_DEF(fn) \
+_RTE_ETH_TX_PROTO(fn) \
+{ \
+	void *txq = _rte_eth_tx_prolog(port_id, queue_id, tx_pkts, &nb_pkts); \
+	if (txq == NULL) \
+		return 0; \
+	return fn(txq, tx_pkts, nb_pkts); \
+}

total: 1 errors, 1 warnings, 747 lines checked
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)

           reply	other threads:[~2021-08-20 16:30 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20210820162834.12544-4-konstantin.ananyev@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210820163028.BCAB81226B3@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).