From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9CD1A0C4D for ; Fri, 20 Aug 2021 18:30:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B64344121C; Fri, 20 Aug 2021 18:30:29 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id C3E9B4003E for ; Fri, 20 Aug 2021 18:30:28 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id BCAB81226B3; Fri, 20 Aug 2021 18:30:28 +0200 (CEST) In-Reply-To: <20210820162834.12544-4-konstantin.ananyev@intel.com> References: <20210820162834.12544-4-konstantin.ananyev@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Konstantin Ananyev Message-Id: <20210820163028.BCAB81226B3@dpdk.org> Date: Fri, 20 Aug 2021 18:30:28 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw97169 [RFC 3/7] eth: make drivers to use new API for Tx X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/97169 _coding style issues_ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #242: FILE: drivers/net/i40e/i40e_rxtx.c:3574: + _RTE_ETH_FUNC( ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #841: FILE: lib/ethdev/ethdev_driver.h:1715: +#define _RTE_ETH_TX_DEF(fn) \ +_RTE_ETH_TX_PROTO(fn) \ +{ \ + void *txq = _rte_eth_tx_prolog(port_id, queue_id, tx_pkts, &nb_pkts); \ + if (txq == NULL) \ + return 0; \ + return fn(txq, tx_pkts, nb_pkts); \ +} WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #841: FILE: lib/ethdev/ethdev_driver.h:1715: +#define _RTE_ETH_TX_DEF(fn) \ +_RTE_ETH_TX_PROTO(fn) \ +{ \ + void *txq = _rte_eth_tx_prolog(port_id, queue_id, tx_pkts, &nb_pkts); \ + if (txq == NULL) \ + return 0; \ + return fn(txq, tx_pkts, nb_pkts); \ +} total: 1 errors, 1 warnings, 747 lines checked Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c) Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)