From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDB59A0C4D for ; Fri, 20 Aug 2021 18:30:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9B5E4117A; Fri, 20 Aug 2021 18:30:35 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id E32B14003E for ; Fri, 20 Aug 2021 18:30:33 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id DF1C21226B3; Fri, 20 Aug 2021 18:30:33 +0200 (CEST) In-Reply-To: <20210820162834.12544-6-konstantin.ananyev@intel.com> References: <20210820162834.12544-6-konstantin.ananyev@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Konstantin Ananyev Message-Id: <20210820163033.DF1C21226B3@dpdk.org> Date: Fri, 20 Aug 2021 18:30:33 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw97171 [RFC 5/7] eth: make drivers to use new API to obtain descriptor status X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/97171 _coding style issues_ ERROR:CODE_INDENT: code indent should use tabs where possible #263: FILE: lib/ethdev/ethdev_driver.h:1824: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #263: FILE: lib/ethdev/ethdev_driver.h:1824: + return 0;$ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #280: FILE: lib/ethdev/ethdev_driver.h:1841: +#define _RTE_ETH_RX_DESC_DEF(fn) \ +_RTE_ETH_RX_DESC_PROTO(fn) \ +{ \ + int rc; \ + void *rxq; \ + rc = _rte_eth_rx_desc_prolog(port_id, queue_id, &rxq); \ + if (rc != 0) \ + return rc; \ + return fn(rxq, offset); \ +} WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #280: FILE: lib/ethdev/ethdev_driver.h:1841: +#define _RTE_ETH_RX_DESC_DEF(fn) \ +_RTE_ETH_RX_DESC_PROTO(fn) \ +{ \ + int rc; \ + void *rxq; \ + rc = _rte_eth_rx_desc_prolog(port_id, queue_id, &rxq); \ + if (rc != 0) \ + return rc; \ + return fn(rxq, offset); \ +} ERROR:CODE_INDENT: code indent should use tabs where possible #329: FILE: lib/ethdev/ethdev_driver.h:1890: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #329: FILE: lib/ethdev/ethdev_driver.h:1890: + return 0;$ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #346: FILE: lib/ethdev/ethdev_driver.h:1907: +#define _RTE_ETH_TX_DESC_DEF(fn) \ +_RTE_ETH_TX_DESC_PROTO(fn) \ +{ \ + int rc; \ + void *txq; \ + rc = _rte_eth_tx_desc_prolog(port_id, queue_id, &txq); \ + if (rc != 0) \ + return rc; \ + return fn(txq, offset); \ +} WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #346: FILE: lib/ethdev/ethdev_driver.h:1907: +#define _RTE_ETH_TX_DESC_DEF(fn) \ +_RTE_ETH_TX_DESC_PROTO(fn) \ +{ \ + int rc; \ + void *txq; \ + rc = _rte_eth_tx_desc_prolog(port_id, queue_id, &txq); \ + if (rc != 0) \ + return rc; \ + return fn(txq, offset); \ +} total: 4 errors, 4 warnings, 378 lines checked Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c) Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c) Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)