From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E780DA0C47 for ; Thu, 2 Sep 2021 14:21:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E31824013F; Thu, 2 Sep 2021 14:21:29 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 5A1944003E for ; Thu, 2 Sep 2021 14:21:29 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 54686122E33; Thu, 2 Sep 2021 14:21:29 +0200 (CEST) In-Reply-To: <61c10bd36641c9d241c8ce2ab7b2544437b714c5.1630584303.git.sthotton@marvell.com> References: <61c10bd36641c9d241c8ce2ab7b2544437b714c5.1630584303.git.sthotton@marvell.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Shijith Thotton Message-Id: <20210902122129.54686122E33@dpdk.org> Date: Thu, 2 Sep 2021 14:21:29 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw97786 [PATCH v2 2/8] event/cnxk: add macro to set eventdev ops X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/97786 _coding style issues_ WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop #97: FILE: drivers/event/cnxk/cn10k_eventdev.c:9: +#define CN10K_SET_EVDEV_DEQ_OP(dev, deq_op, deq_ops) \ + do { \ + deq_op = deq_ops \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_VLAN_STRIP_F)] \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_TSTAMP_F)] \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_MARK_UPDATE_F)] \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_CHECKSUM_F)] \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_PTYPE_F)] \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_RSS_F)]; \ + } while (0) WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop #108: FILE: drivers/event/cnxk/cn10k_eventdev.c:20: +#define CN10K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops) \ + do { \ + enq_op = enq_ops \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSTAMP_F)] \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSO_F)] \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_MBUF_NOFF_F)] \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_VLAN_QINQ_F)] \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_OL3_OL4_CSUM_F)] \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_L3_L4_CSUM_F)]; \ + } while (0) WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop #295: FILE: drivers/event/cnxk/cn9k_eventdev.c:12: +#define CN9K_SET_EVDEV_DEQ_OP(dev, deq_op, deq_ops) \ + do { \ + deq_op = deq_ops \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_VLAN_STRIP_F)] \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_TSTAMP_F)] \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_MARK_UPDATE_F)] \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_CHECKSUM_F)] \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_PTYPE_F)] \ + [!!(dev->rx_offloads & NIX_RX_OFFLOAD_RSS_F)]; \ + } while (0) WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop #306: FILE: drivers/event/cnxk/cn9k_eventdev.c:23: +#define CN9K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops) \ + do { \ + enq_op = enq_ops \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSTAMP_F)] \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSO_F)] \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_MBUF_NOFF_F)] \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_VLAN_QINQ_F)] \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_OL3_OL4_CSUM_F)] \ + [!!(dev->tx_offloads & NIX_TX_OFFLOAD_L3_L4_CSUM_F)]; \ + } while (0) total: 0 errors, 4 warnings, 493 lines checked