* [dpdk-test-report] |WARNING| pw97786 [PATCH v2 2/8] event/cnxk: add macro to set eventdev ops
[not found] <61c10bd36641c9d241c8ce2ab7b2544437b714c5.1630584303.git.sthotton@marvell.com>
@ 2021-09-02 12:21 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-09-02 12:21 UTC (permalink / raw)
To: test-report; +Cc: Shijith Thotton
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97786
_coding style issues_
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#97: FILE: drivers/event/cnxk/cn10k_eventdev.c:9:
+#define CN10K_SET_EVDEV_DEQ_OP(dev, deq_op, deq_ops) \
+ do { \
+ deq_op = deq_ops \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_VLAN_STRIP_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_TSTAMP_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_MARK_UPDATE_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_CHECKSUM_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_PTYPE_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_RSS_F)]; \
+ } while (0)
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#108: FILE: drivers/event/cnxk/cn10k_eventdev.c:20:
+#define CN10K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops) \
+ do { \
+ enq_op = enq_ops \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSTAMP_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSO_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_MBUF_NOFF_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_VLAN_QINQ_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_OL3_OL4_CSUM_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_L3_L4_CSUM_F)]; \
+ } while (0)
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#295: FILE: drivers/event/cnxk/cn9k_eventdev.c:12:
+#define CN9K_SET_EVDEV_DEQ_OP(dev, deq_op, deq_ops) \
+ do { \
+ deq_op = deq_ops \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_VLAN_STRIP_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_TSTAMP_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_MARK_UPDATE_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_CHECKSUM_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_PTYPE_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_RSS_F)]; \
+ } while (0)
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#306: FILE: drivers/event/cnxk/cn9k_eventdev.c:23:
+#define CN9K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops) \
+ do { \
+ enq_op = enq_ops \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSTAMP_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSO_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_MBUF_NOFF_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_VLAN_QINQ_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_OL3_OL4_CSUM_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_L3_L4_CSUM_F)]; \
+ } while (0)
total: 0 errors, 4 warnings, 493 lines checked
^ permalink raw reply [flat|nested] only message in thread