From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 41B8EA0C4D
	for <public@inbox.dpdk.org>; Fri,  3 Sep 2021 02:49:08 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3E11940041;
	Fri,  3 Sep 2021 02:49:08 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 495F14003E
 for <test-report@dpdk.org>; Fri,  3 Sep 2021 02:49:07 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 3FBB0122E33; Fri,  3 Sep 2021 02:49:07 +0200 (CEST)
In-Reply-To: <20210903004732.109023-4-stephen@networkplumber.org>
References: <20210903004732.109023-4-stephen@networkplumber.org>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20210903004907.3FBB0122E33@dpdk.org>
Date: Fri,  3 Sep 2021 02:49:07 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw97853 [PATCH 3/5] app/dumpcap: add
 new packet capture application
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97853

_coding style issues_


WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'autostop', this function's name, in a string
#272: FILE: app/dumpcap/main.c:172:
+			 "Unknown autostop parameter \"%s\"
", opt);

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#598: FILE: app/dumpcap/main.c:498:
+	const char *args[] = {

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#623: FILE: app/dumpcap/main.c:523:
+	struct rte_ring *pring;

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#637: FILE: app/dumpcap/main.c:537:
+	pring = rte_ring_lookup(RING_NAME);

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#638: FILE: app/dumpcap/main.c:538:
+	if (pring == NULL) {

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#639: FILE: app/dumpcap/main.c:539:
+		pring = rte_ring_create(RING_NAME, ring_size,

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#641: FILE: app/dumpcap/main.c:541:
+		if (pring == NULL)

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#645: FILE: app/dumpcap/main.c:545:
+	return pring;

WARNING:TYPO_SPELLING: 'CREAT' may be misspelled - perhaps 'CREATE'?
#705: FILE: app/dumpcap/main.c:605:
+		fd = open(output_name, O_WRONLY | O_CREAT, mode);

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#725: FILE: app/dumpcap/main.c:625:
+		return pcapng;
+	} else {

total: 0 errors, 10 warnings, 847 lines checked