From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 20AA0A0C45
	for <public@inbox.dpdk.org>; Wed, 22 Sep 2021 10:56:59 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 14C7B41196;
	Wed, 22 Sep 2021 10:56:59 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id E67BD4069E
 for <test-report@dpdk.org>; Wed, 22 Sep 2021 10:56:57 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id C743C122EE7; Wed, 22 Sep 2021 10:56:57 +0200 (CEST)
In-Reply-To: <20210922084633.166409-1-simei.su@intel.com>
References: <20210922084633.166409-1-simei.su@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Simei Su <simei.su@intel.com>
Message-Id: <20210922085657.C743C122EE7@dpdk.org>
Date: Wed, 22 Sep 2021 10:56:57 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw99406 [PATCH v4] net/ice: support
 IEEE 1588 PTP for E810
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/99406

_coding style issues_


CHECK:BRACES: braces {} should be used on all arms of this statement
#173: FILE: drivers/net/ice/ice_ethdev.c:5520:
+	if (!dev->data->dev_started)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#175: FILE: drivers/net/ice/ice_ethdev.c:5522:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#176: FILE: drivers/net/ice/ice_ethdev.c:5523:
+		if (!(dev->data->dev_conf.rxmode.offloads &
[...]
+		} else
[...]

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#180: FILE: drivers/net/ice/ice_ethdev.c:5527:
+			return -1;
+		} else

CHECK:BRACES: Unbalanced braces around else statement
#180: FILE: drivers/net/ice/ice_ethdev.c:5527:
+		} else

CHECK:BRACES: braces {} should be used on all arms of this statement
#381: FILE: drivers/net/ice/ice_rxtx.c:370:
+	if (!ad->ptp_ena) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#384: FILE: drivers/net/ice/ice_rxtx.c:373:
+	} else

CHECK:BRACES: Unbalanced braces around else statement
#480: FILE: drivers/net/ice/ice_rxtx.c:2811:
+			else {

total: 0 errors, 1 warnings, 7 checks, 374 lines checked