From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: [dpdk-test-report] |WARNING| pw99561 [PATCH] [v3] net/ice: support IPv4/L4 checksum RSS offload
Date: Wed, 6 Oct 2021 12:14:05 +0000 (UTC) [thread overview]
Message-ID: <20211006121405.885D660290@dpdk-ubuntu.dpdklab.iol.unh.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 5915 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/99561
_apply patch failure_
Submitter: Alvin Zhang <alvinx.zhang@intel.com>
Date: Friday, September 24 2021 09:53:41
Applied on: CommitID:2700326085033fd13339a8de31f58a95d1ee9c3f
Apply patch set 99561 failed:
Checking patch doc/guides/rel_notes/release_21_11.rst...
error: while searching for:
* **Updated Intel ice driver.**
Added 1PPS out support by a devargs.
* **Updated Marvell cnxk ethdev driver.**
error: patch failed: doc/guides/rel_notes/release_21_11.rst:75
Checking patch drivers/net/ice/ice_hash.c...
error: while searching for:
/* IPv4 */
#define ICE_RSS_TYPE_ETH_IPV4 (ETH_RSS_ETH | ETH_RSS_IPV4 | \
ETH_RSS_FRAG_IPV4)
#define ICE_RSS_TYPE_ETH_IPV4_UDP (ICE_RSS_TYPE_ETH_IPV4 | \
ETH_RSS_NONFRAG_IPV4_UDP)
#define ICE_RSS_TYPE_ETH_IPV4_TCP (ICE_RSS_TYPE_ETH_IPV4 | \
ETH_RSS_NONFRAG_IPV4_TCP)
#define ICE_RSS_TYPE_ETH_IPV4_SCTP (ICE_RSS_TYPE_ETH_IPV4 | \
ETH_RSS_NONFRAG_IPV4_SCTP)
#define ICE_RSS_TYPE_IPV4 ETH_RSS_IPV4
#define ICE_RSS_TYPE_IPV4_UDP (ETH_RSS_IPV4 | \
ETH_RSS_NONFRAG_IPV4_UDP)
error: patch failed: drivers/net/ice/ice_hash.c:374
error: while searching for:
#define ICE_RSS_TYPE_ETH_IPV6_FRAG (ETH_RSS_ETH | ETH_RSS_IPV6 | \
ETH_RSS_FRAG_IPV6)
#define ICE_RSS_TYPE_ETH_IPV6_UDP (ICE_RSS_TYPE_ETH_IPV6 | \
ETH_RSS_NONFRAG_IPV6_UDP)
#define ICE_RSS_TYPE_ETH_IPV6_TCP (ICE_RSS_TYPE_ETH_IPV6 | \
ETH_RSS_NONFRAG_IPV6_TCP)
#define ICE_RSS_TYPE_ETH_IPV6_SCTP (ICE_RSS_TYPE_ETH_IPV6 | \
ETH_RSS_NONFRAG_IPV6_SCTP)
#define ICE_RSS_TYPE_IPV6 ETH_RSS_IPV6
#define ICE_RSS_TYPE_IPV6_UDP (ETH_RSS_IPV6 | \
ETH_RSS_NONFRAG_IPV6_UDP)
error: patch failed: drivers/net/ice/ice_hash.c:394
error: while searching for:
} else {
*hash_flds &= ~ICE_FLOW_HASH_IPV4;
}
}
if (*addl_hdrs & ICE_FLOW_SEG_HDR_IPV6) {
error: patch failed: drivers/net/ice/ice_hash.c:689
error: while searching for:
} else {
*hash_flds &= ~ICE_FLOW_HASH_UDP_PORT;
}
}
if (*addl_hdrs & ICE_FLOW_SEG_HDR_TCP) {
error: patch failed: drivers/net/ice/ice_hash.c:765
error: while searching for:
} else {
*hash_flds &= ~ICE_FLOW_HASH_TCP_PORT;
}
}
if (*addl_hdrs & ICE_FLOW_SEG_HDR_SCTP) {
error: patch failed: drivers/net/ice/ice_hash.c:782
error: while searching for:
} else {
*hash_flds &= ~ICE_FLOW_HASH_SCTP_PORT;
}
}
if (*addl_hdrs & ICE_FLOW_SEG_HDR_L2TPV3) {
error: patch failed: drivers/net/ice/ice_hash.c:799
Applying patch doc/guides/rel_notes/release_21_11.rst with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/ice/ice_hash.c with 6 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
Rejected hunk #4.
Rejected hunk #5.
Rejected hunk #6.
diff a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst (rejected hunks)
@@ -75,7 +75,8 @@ New Features
* **Updated Intel ice driver.**
- Added 1PPS out support by a devargs.
+ * Added 1PPS out support by a devargs.
+ * Added IPv4 and L4(TCP/UDP/SCTP) checksum hash support in RSS flow.
* **Updated Marvell cnxk ethdev driver.**
diff a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c (rejected hunks)
@@ -374,13 +374,17 @@ struct ice_rss_hash_cfg eth_tmplt = {
/* IPv4 */
#define ICE_RSS_TYPE_ETH_IPV4 (ETH_RSS_ETH | ETH_RSS_IPV4 | \
- ETH_RSS_FRAG_IPV4)
+ ETH_RSS_FRAG_IPV4 | \
+ ETH_RSS_IPV4_CHKSUM)
#define ICE_RSS_TYPE_ETH_IPV4_UDP (ICE_RSS_TYPE_ETH_IPV4 | \
- ETH_RSS_NONFRAG_IPV4_UDP)
+ ETH_RSS_NONFRAG_IPV4_UDP | \
+ ETH_RSS_L4_CHKSUM)
#define ICE_RSS_TYPE_ETH_IPV4_TCP (ICE_RSS_TYPE_ETH_IPV4 | \
- ETH_RSS_NONFRAG_IPV4_TCP)
+ ETH_RSS_NONFRAG_IPV4_TCP | \
+ ETH_RSS_L4_CHKSUM)
#define ICE_RSS_TYPE_ETH_IPV4_SCTP (ICE_RSS_TYPE_ETH_IPV4 | \
- ETH_RSS_NONFRAG_IPV4_SCTP)
+ ETH_RSS_NONFRAG_IPV4_SCTP | \
+ ETH_RSS_L4_CHKSUM)
#define ICE_RSS_TYPE_IPV4 ETH_RSS_IPV4
#define ICE_RSS_TYPE_IPV4_UDP (ETH_RSS_IPV4 | \
ETH_RSS_NONFRAG_IPV4_UDP)
@@ -394,11 +398,14 @@ struct ice_rss_hash_cfg eth_tmplt = {
#define ICE_RSS_TYPE_ETH_IPV6_FRAG (ETH_RSS_ETH | ETH_RSS_IPV6 | \
ETH_RSS_FRAG_IPV6)
#define ICE_RSS_TYPE_ETH_IPV6_UDP (ICE_RSS_TYPE_ETH_IPV6 | \
- ETH_RSS_NONFRAG_IPV6_UDP)
+ ETH_RSS_NONFRAG_IPV6_UDP | \
+ ETH_RSS_L4_CHKSUM)
#define ICE_RSS_TYPE_ETH_IPV6_TCP (ICE_RSS_TYPE_ETH_IPV6 | \
- ETH_RSS_NONFRAG_IPV6_TCP)
+ ETH_RSS_NONFRAG_IPV6_TCP | \
+ ETH_RSS_L4_CHKSUM)
#define ICE_RSS_TYPE_ETH_IPV6_SCTP (ICE_RSS_TYPE_ETH_IPV6 | \
- ETH_RSS_NONFRAG_IPV6_SCTP)
+ ETH_RSS_NONFRAG_IPV6_SCTP | \
+ ETH_RSS_L4_CHKSUM)
#define ICE_RSS_TYPE_IPV6 ETH_RSS_IPV6
#define ICE_RSS_TYPE_IPV6_UDP (ETH_RSS_IPV6 | \
ETH_RSS_NONFRAG_IPV6_UDP)
@@ -689,6 +696,9 @@ struct ice_rss_hash_cfg eth_tmplt = {
} else {
*hash_flds &= ~ICE_FLOW_HASH_IPV4;
}
+
+ if (rss_type & ETH_RSS_IPV4_CHKSUM)
+ *hash_flds |= BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_CHKSUM);
}
if (*addl_hdrs & ICE_FLOW_SEG_HDR_IPV6) {
@@ -765,6 +775,9 @@ struct ice_rss_hash_cfg eth_tmplt = {
} else {
*hash_flds &= ~ICE_FLOW_HASH_UDP_PORT;
}
+
+ if (rss_type & ETH_RSS_L4_CHKSUM)
+ *hash_flds |= BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_CHKSUM);
}
if (*addl_hdrs & ICE_FLOW_SEG_HDR_TCP) {
@@ -782,6 +795,9 @@ struct ice_rss_hash_cfg eth_tmplt = {
} else {
*hash_flds &= ~ICE_FLOW_HASH_TCP_PORT;
}
+
+ if (rss_type & ETH_RSS_L4_CHKSUM)
+ *hash_flds |= BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_CHKSUM);
}
if (*addl_hdrs & ICE_FLOW_SEG_HDR_SCTP) {
@@ -799,6 +815,9 @@ struct ice_rss_hash_cfg eth_tmplt = {
} else {
*hash_flds &= ~ICE_FLOW_HASH_SCTP_PORT;
}
+
+ if (rss_type & ETH_RSS_L4_CHKSUM)
+ *hash_flds |= BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_CHKSUM);
}
if (*addl_hdrs & ICE_FLOW_SEG_HDR_L2TPV3) {
https://lab.dpdk.org/results/dashboard/patchsets/18938/
UNH-IOL DPDK Community Lab
reply other threads:[~2021-10-06 12:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006121405.885D660290@dpdk-ubuntu.dpdklab.iol.unh.edu \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).