automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: [dpdk-test-report] |WARNING| pw101206 [PATCH v4 5/5] app/testpmd: add flex item CLI commands
Date: Tue, 12 Oct 2021 13:34:46 +0200 (CEST)	[thread overview]
Message-ID: <20211012113446.4C21A120E00@dpdk.org> (raw)
In-Reply-To: <20211012113235.24975-6-viacheslavo@nvidia.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/101206

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#640: FILE: app/test-pmd/cmdline_flow.c:9119:
+#define FLEX_FIELD_GET(fm, t) \
+do {                  \
+	if (!strncmp(key, # fm, strlen(# fm))) { \
+		if (json_is_real(je))   \
+			fld->fm = (t) json_real_value(je); \
+		else if (json_is_integer(je))   \
+			fld->fm = (t) json_integer_value(je); \
+		else   \
+			return -EINVAL; \
+	}         \
+} while (0)

ERROR:CODE_INDENT: code indent should use tabs where possible
#855: FILE: app/test-pmd/cmdline_flow.c:9334:
+^I^I^I         sizeof(conf->sample_data[0]),$

total: 1 errors, 1 warnings, 1053 lines checked

       reply	other threads:[~2021-10-12 11:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211012113235.24975-6-viacheslavo@nvidia.com>
2021-10-12 11:34 ` checkpatch [this message]
2021-10-12 11:59 ` [dpdk-test-report] |SUCCESS| pw101206 [dpdk-dev] " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012113446.4C21A120E00@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).