From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 600BFA0C47
	for <public@inbox.dpdk.org>; Tue, 12 Oct 2021 13:34:47 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5C24041143;
	Tue, 12 Oct 2021 13:34:47 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 53A534113A
 for <test-report@dpdk.org>; Tue, 12 Oct 2021 13:34:46 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 4C21A120E00; Tue, 12 Oct 2021 13:34:46 +0200 (CEST)
In-Reply-To: <20211012113235.24975-6-viacheslavo@nvidia.com>
References: <20211012113235.24975-6-viacheslavo@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Message-Id: <20211012113446.4C21A120E00@dpdk.org>
Date: Tue, 12 Oct 2021 13:34:46 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw101206 [PATCH v4 5/5] app/testpmd:
 add flex item CLI commands
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/101206

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#640: FILE: app/test-pmd/cmdline_flow.c:9119:
+#define FLEX_FIELD_GET(fm, t) \
+do {                  \
+	if (!strncmp(key, # fm, strlen(# fm))) { \
+		if (json_is_real(je))   \
+			fld->fm = (t) json_real_value(je); \
+		else if (json_is_integer(je))   \
+			fld->fm = (t) json_integer_value(je); \
+		else   \
+			return -EINVAL; \
+	}         \
+} while (0)

ERROR:CODE_INDENT: code indent should use tabs where possible
#855: FILE: app/test-pmd/cmdline_flow.c:9334:
+^I^I^I         sizeof(conf->sample_data[0]),$

total: 1 errors, 1 warnings, 1053 lines checked