From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53731A0C47 for ; Tue, 12 Oct 2021 14:57:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47D0F4111E; Tue, 12 Oct 2021 14:57:24 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id C4A7A40E0F for ; Tue, 12 Oct 2021 14:57:22 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id A9514120E00; Tue, 12 Oct 2021 14:57:22 +0200 (CEST) In-Reply-To: <20211012125433.31647-6-viacheslavo@nvidia.com> References: <20211012125433.31647-6-viacheslavo@nvidia.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Viacheslav Ovsiienko Message-Id: <20211012125722.A9514120E00@dpdk.org> Date: Tue, 12 Oct 2021 14:57:22 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw101228 [PATCH v5 5/5] app/testpmd: add flex item CLI commands X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/101228 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #640: FILE: app/test-pmd/cmdline_flow.c:9119: +#define FLEX_FIELD_GET(fm, t) \ +do { \ + if (!strncmp(key, # fm, strlen(# fm))) { \ + if (json_is_real(je)) \ + fld->fm = (t) json_real_value(je); \ + else if (json_is_integer(je)) \ + fld->fm = (t) json_integer_value(je); \ + else \ + return -EINVAL; \ + } \ +} while (0) total: 0 errors, 1 warnings, 1053 lines checked