automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Harman Kalra <hkalra@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw102694 [PATCH v5 1/6] eal/interrupts: implement get set APIs
Date: Fri, 22 Oct 2021 22:50:22 +0200 (CEST)	[thread overview]
Message-ID: <20211022205022.A64FD121E15@dpdk.org> (raw)
In-Reply-To: <20211022204934.132186-2-hkalra@marvell.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/102694

_coding style issues_


WARNING:TYPO_SPELLING: 'wont' may be misspelled - perhaps 'won't'?
#78: 
User wont be able to access any of the interrupt handle fields

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#133: FILE: lib/eal/common/eal_common_interrupts.c:14:
+#define CHECK_VALID_INTR_HANDLE(intr_handle) do { \
+	if (intr_handle == NULL) { \
+		RTE_LOG(ERR, EAL, "Interrupt instance unallocated
"); \
+		rte_errno = EINVAL; \
+		goto fail; \
+	} \
+} while (0)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#145: FILE: lib/eal/common/eal_common_interrupts.c:26:
+#define IS_RTE_MEMORY(intr_handle)		\
+		!!(intr_handle->alloc_flag & RTE_INTR_INSTANCE_F_SHARED)

total: 1 errors, 2 warnings, 1531 lines checked

           reply	other threads:[~2021-10-22 20:50 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20211022204934.132186-2-hkalra@marvell.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211022205022.A64FD121E15@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).