From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E6FC2A0C43
	for <public@inbox.dpdk.org>; Fri, 22 Oct 2021 22:50:23 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E0D2B410F2;
	Fri, 22 Oct 2021 22:50:23 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id C666A410E9
 for <test-report@dpdk.org>; Fri, 22 Oct 2021 22:50:22 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id A64FD121E15; Fri, 22 Oct 2021 22:50:22 +0200 (CEST)
In-Reply-To: <20211022204934.132186-2-hkalra@marvell.com>
References: <20211022204934.132186-2-hkalra@marvell.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Harman Kalra <hkalra@marvell.com>
Message-Id: <20211022205022.A64FD121E15@dpdk.org>
Date: Fri, 22 Oct 2021 22:50:22 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw102694 [PATCH v5 1/6]
 eal/interrupts: implement get set APIs
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/102694

_coding style issues_


WARNING:TYPO_SPELLING: 'wont' may be misspelled - perhaps 'won't'?
#78: 
User wont be able to access any of the interrupt handle fields

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#133: FILE: lib/eal/common/eal_common_interrupts.c:14:
+#define CHECK_VALID_INTR_HANDLE(intr_handle) do { \
+	if (intr_handle == NULL) { \
+		RTE_LOG(ERR, EAL, "Interrupt instance unallocated
"); \
+		rte_errno = EINVAL; \
+		goto fail; \
+	} \
+} while (0)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#145: FILE: lib/eal/common/eal_common_interrupts.c:26:
+#define IS_RTE_MEMORY(intr_handle)		\
+		!!(intr_handle->alloc_flag & RTE_INTR_INSTANCE_F_SHARED)

total: 1 errors, 2 warnings, 1531 lines checked