From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64280A0C47 for ; Mon, 25 Oct 2021 08:41:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5566E410EB; Mon, 25 Oct 2021 08:41:37 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 2FC6540E3C for ; Mon, 25 Oct 2021 08:41:36 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id ED03A121E15; Mon, 25 Oct 2021 08:41:35 +0200 (CEST) In-Reply-To: <20211025063922.34066-3-humin29@huawei.com> References: <20211025063922.34066-3-humin29@huawei.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: "Min Hu (Connor)" Message-Id: <20211025064135.ED03A121E15@dpdk.org> Date: Mon, 25 Oct 2021 08:41:35 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw102735 [PATCH 2/3] app/testpmd: fix slave device isn't released X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/102735 _coding style issues_ WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #39: Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: fix slave device isn't released WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'? #58: release operation for all active slaves under a bond device. WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #117: FILE: app/test-pmd/testpmd.c:3120: +handle_bonding_slave_device(portid_t bond_pid) WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #119: FILE: app/test-pmd/testpmd.c:3122: + portid_t slave_pids[RTE_MAX_ETHPORTS]; WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #121: FILE: app/test-pmd/testpmd.c:3124: + portid_t slave_pid; WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'? #122: FILE: app/test-pmd/testpmd.c:3125: + int num_slaves; WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'? #125: FILE: app/test-pmd/testpmd.c:3128: + num_slaves = rte_eth_bond_slaves_get(bond_pid, slave_pids, WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'? #125: FILE: app/test-pmd/testpmd.c:3128: + num_slaves = rte_eth_bond_slaves_get(bond_pid, slave_pids, WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #125: FILE: app/test-pmd/testpmd.c:3128: + num_slaves = rte_eth_bond_slaves_get(bond_pid, slave_pids, WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'? #127: FILE: app/test-pmd/testpmd.c:3130: + if (num_slaves < 0) { WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #128: FILE: app/test-pmd/testpmd.c:3131: + fprintf(stderr, "Failed to get slave list for port = %u ", WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'? #133: FILE: app/test-pmd/testpmd.c:3136: + for (i = 0; i < num_slaves; i++) { WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #134: FILE: app/test-pmd/testpmd.c:3137: + slave_pid = slave_pids[i]; WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #134: FILE: app/test-pmd/testpmd.c:3137: + slave_pid = slave_pids[i]; WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #135: FILE: app/test-pmd/testpmd.c:3138: + /* Before removing a slave device, stop the slave device. */ WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #135: FILE: app/test-pmd/testpmd.c:3138: + /* Before removing a slave device, stop the slave device. */ WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #136: FILE: app/test-pmd/testpmd.c:3139: + if (port_is_started(slave_pid) == 1) { WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #137: FILE: app/test-pmd/testpmd.c:3140: + if (rte_eth_dev_stop(slave_pid) != 0) WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #139: FILE: app/test-pmd/testpmd.c:3142: + slave_pid); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #141: FILE: app/test-pmd/testpmd.c:3144: + port = &ports[slave_pid]; WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #145: FILE: app/test-pmd/testpmd.c:3148: + slave_pid); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #149: FILE: app/test-pmd/testpmd.c:3152: + * Remove the slave from a bonded device in case of failing to WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #152: FILE: app/test-pmd/testpmd.c:3155: + if (rte_eth_bond_slave_remove(bond_pid, slave_pid) != 0) WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #152: FILE: app/test-pmd/testpmd.c:3155: + if (rte_eth_bond_slave_remove(bond_pid, slave_pid) != 0) WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #153: FILE: app/test-pmd/testpmd.c:3156: + fprintf(stderr, "Failed to remove slave %u from master port = %u ", WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #153: FILE: app/test-pmd/testpmd.c:3156: + fprintf(stderr, "Failed to remove slave %u from master port = %u ", WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #154: FILE: app/test-pmd/testpmd.c:3157: + slave_pid, bond_pid); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #155: FILE: app/test-pmd/testpmd.c:3158: + clear_port_slave_flag(slave_pid); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #155: FILE: app/test-pmd/testpmd.c:3158: + clear_port_slave_flag(slave_pid); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #157: FILE: app/test-pmd/testpmd.c:3160: + /* Close slave device when testpmd quit or is killed. */ WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #159: FILE: app/test-pmd/testpmd.c:3162: + rte_eth_dev_close(slave_pid); WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'? #173: FILE: app/test-pmd/testpmd.c:3207: + * If this port is bond device, all slaves under the WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #177: FILE: app/test-pmd/testpmd.c:3211: + handle_bonding_slave_device(pi); total: 0 errors, 33 warnings, 105 lines checked Warning in app/test-pmd/testpmd.c: Using rte_atomicNN_xxx